search

KSP-CKAN / CKAN

The Comprehensive Kerbal Archive Network
https://forum.kerbalspaceprogram.com/index.php?/topic/197082-*
Other
1.98k stars 347 forks source link

Scraping from KerbalStuff should give us all authors #1048

Closed Dazpoet closed 8 years ago

Dazpoet commented 9 years ago

https://github.com/KSP-CKAN/NetKAN/pull/1452 has a $kref pointing to https://kerbalstuff.com/mod/855/Antares%20%26%20Cygnus which lists 2 mod authors. However the generated .ckan file in the log output from Jenkins looks like this

{
    ...
    "author": "RaiderNick",
    ...
}

While one would expect it to be

{
    ...
    "author": [ "RaiderNick", "Kartoffelkuchen" ],
    ...
}
RichardLake commented 9 years ago

Looking at https://kerbalstuff.com/api/mod/855 the kerbalstuff API is not sending both authors. While netkan may need changes if it did it would need to be fixed on KS's side as well.

Dazpoet commented 9 years ago

That would indeed nullify my proposal until such a time that the KS API lists all authors, I'll go open an issue over there to see what can be done.

Dazpoet commented 8 years ago

Seeing as KS no longer exists this is now a null subject and henceforth I'm closing it.

mheguy commented 8 years ago

In before "Scraping from SpaceDock should give us all authors" :)

Dazpoet commented 8 years ago

:smiling_imp: