KSP-CKAN / CKAN

The Comprehensive Kerbal Archive Network
https://forum.kerbalspaceprogram.com/index.php?/topic/197082-*
Other
1.97k stars 347 forks source link

Cannot install Scatterer #1870

Closed amywarble closed 8 years ago

amywarble commented 8 years ago

Version: CKAN v1.18.1-g0d2cf40 (beta) - KSP 1.1.3.1289

OS: Windows 8.1

Issue: Clicking the checkbox next to Scatterer causes a crash.

To reproduce: Find Scatterer in the modules list. Click the checkbox next to it so that it is checked. CKAN will immediately crash.

************** Exception Text **************
System.ArgumentException: Already contains module:Scatterer
   at CKAN.RelationshipResolver.Add(CkanModule module, SelectionReason reason)
   at CKAN.RelationshipResolver.AddModulesToInstall(IEnumerable`1 modules)
   at CKAN.RelationshipResolver..ctor(IEnumerable`1 module_names, RelationshipResolverOptions options, IRegistryQuerier registry, KspVersion kspversion)
   at CKAN.MainModList.ComputeConflictsFromModList(IRegistryQuerier registry, IEnumerable`1 change_set, KspVersion ksp_version)
   at CKAN.Main.<UpdateChangeSetAndConflicts>c__async1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at CKAN.Main.<ModList_CellValueChanged>c__async0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__6_0(Object state)
politas commented 8 years ago

Can you give us some history of your installation? Have you previously installed anything like Stock Visual Enhancements or Renaissance Compilation, using CKAN or otherwise?

amywarble commented 8 years ago

I recently wiped my KSP folder and reinstalled the game from Steam.

Here is my exported mods list: https://gist.github.com/amyhickman/60f16ac1243190e5baf06b0cb47bda60

politas commented 8 years ago

Ok, you've got SVE-HighResolution installed, which actually includes Scatterer. That's why it won't let you install it. It's done a bit differently to our normal dependencies because the author grabs a copy of the Scatterer code and builds to that, not paying attention to the actual Scatterer releases.

ayan4m1 commented 8 years ago

Pretty sure the crash is caused by "scatterer" vs "Scatterer" at some level.

amywarble commented 8 years ago

@politas You're right, I didn't know that about SVE - thank you.

politas commented 8 years ago

ayan4m1, that shouldn't be a problem scatterer is the name, but Scatterer is the identifier, and is what is used in the conflicts and provides statements.

politas commented 8 years ago

No, it would be because Scatterer doesn't conflict with Scatterer.

netkan-bot commented 8 years ago

Hey there! I'm a fun-loving automated bot who's responsible for making sure old support tickets get closed out. As we haven't seen any activity on this ticket for a while, we're hoping the problem has been resolved and I'm closing out the ticket automaically. If I'm doing this in error, please add a comment to this ticket to let us know, and we'll re-open it!