KSP-CKAN / CKAN

The Comprehensive Kerbal Archive Network
https://forum.kerbalspaceprogram.com/index.php?/topic/197082-*
Other
1.99k stars 348 forks source link

Adding a new KSP1 instance should allow for selecting the ksp_x64 exe to reduce confusion #3962

Closed JonnyOThan closed 11 months ago

JonnyOThan commented 11 months ago

This is especially bad because if you don't have file extensions enabled, the file filter dropdown only says "build metadata file" and doesn't tell you WHAT file it's looking for.

HebaruSan commented 11 months ago

It's because that file is only on Windows. On Linux:

~/.local/share/Steam/steamapps/common/Kerbal Space Program$ ls -gGh
...
-rwxrwxr-x  1 6.2K 2021-06-24 12:49 PM KSP.x86_64
...

And the file contents/format are completely different.

If KSP2 ever releases for other platforms, we're going to have to beg the devs to add a buildID.txt equivalent file and do the same thing over there.

JonnyOThan commented 11 months ago

Is there really no possible solution here? Can’t the file filter just include all possible exe names?

HebaruSan commented 11 months ago

I guess we could still get the version info from buildID.txt but have the add-instance window prompt for something else.

Can you find somebody with KSP1 on Mac? The GUI doesn't run there anymore, but it might again someday if we get .NET7 figured out, and I can't remember whether GameData is inside or outside the KSP.app bundle.

HebaruSan commented 11 months ago

Found one on Discord#macos. KSP.app is the closest thing to KSP_x64.exe, but unfortunately an app bundle is a directory at the filesystem level, so the file selection prompt can't pick KSP.app.

image

HebaruSan commented 11 months ago

Side note, oh boy, this is going to break when KSP2 starts installing mods to GameData/Mods.

https://github.com/KSP-CKAN/CKAN/blob/517be692f0bb1ccb9aafed4c8b4b9d7ebb832259/Core/Games/KerbalSpaceProgram.cs#L23-L24