KSP-CKAN / CKAN

The Comprehensive Kerbal Archive Network
https://forum.kerbalspaceprogram.com/index.php?/topic/197082-*
Other
1.98k stars 347 forks source link

[Bug]: Install from .ckan - Unable to skip mods that fail to download in the "depends" section #4234

Closed RaynorD closed 6 days ago

RaynorD commented 6 days ago

Is there an existing issue for this?

Operating System

Windows 11

CKAN Version

1.35.2.24280

Games

KSP 1

Game Version

1.12.5

Did you make any manual changes to your game folder (i.e., not via CKAN)?

No

Describe the bug

Background

Archive.org is currently returning a 503 for all files. I went to install Community Lifeboat Modpack2.ckan. In this pack, ExtraPlanetaryLaunchpads and Custom Asteroids are on Archive.org and cannot be downloaded. This pack uses the "depends" section to list the mods for download.

Behavior

First install attempt I get this dialog: image (Possibly related: Notice that ExtraPlanetaryLaunchpads is not in the failed downloads list. I've tested this link and confirm it returns 503.) I select Skip for both files and hit Retry.

Second install attempt, CKAN is still attempting to download both files: image

I can repeat this process indefinitely and the mods are always in the download list. My only path forward is Abort whole changeset.

Difference from working modpack

I checked a different modpack that includes ExtraPlanetaryLaunchpads, but noticed it uses the "recommends" section to install the mods. CKAN behaves in this case, allowing me to skip mods that fail to download.

Expected Behavior

I'm unsure if modpacks are within the intended scope of the .ckan file format, but if so, "depends" seems like it should be usable for a modpack to get the intended game state.

Thank you for the awesome tool.

Steps to reproduce

  1. Download Community Lifeboat Modpack2.ckan
  2. File > Install from .ckan > Select the file
  3. Uncheck all recommended
  4. Select Skip for all mods in the Download Failed popup
  5. Hit Retry
  6. Repeat steps 4 and 5 as many times as you like
  7. Modify Community Lifeboat Modpack2.ckan line 11 from "depends" to "recommends" and retry Install from .ckan
  8. Skip and retry for any failed downloads

Relevant log output

Click to expand ``` About to install: * VertexColorMapEmissive 1.0.0 (cached) * ReStock 1.5.0 (cached) * VertexHeightOblateAdvanced 1.1.4 (cached) * Custom Asteroids (alternative OPM config) v1.2.0 (api.github.com, 8.9 KiB) * Custom Asteroids (Kuiper belt analog for OPM) v1.2.0 (api.github.com, 8.9 KiB) * Community Resource Pack v112.0.1 (cached) * ModularFlightIntegrator 1.2.10.0 (cached) * Kopernicus Planetary System Modifier 2:release-1.12.1-214 (cached) * Contract Configurator v2.11.0.0 (cached) * Dynamic Battery Storage 2:2.3.3.0 (cached) * USI Tools v112.0.1 (cached) * Deployable Engines Plugin 1.3.1 (cached) * System Heat 0.7.5 (cached) * Community Terrain Texture Pack 1:1.0.5 (cached) * Cryo Tanks 1.6.6 (cached) * Cryo Tanks Core 1.6.6 (cached) * Firespitter Core v7.17 (cached) * Community Category Kit v112.0.1 (cached) * Outer Planets Mod 2:2.2.11 (cached) * USI Core v112.0.1 (cached) * Custom Asteroids v1.9.0 (cached) * Custom Asteroids (inner stock system data) v1.9.0 (cached) * Custom Pre Launch Checks 1.8.1.1 (cached) * Near Future IVA Props 1:0.7.2 (cached) * Parallax 2.0.8 (cached) * Parallax - Stock Planet Textures 2.0.8 (cached) * Parallax - Stock Scatter Textures 2.0.8 (cached) * Vertex Mitchell-Netravali Filtered Heightmap 0.3 (cached) * AT Utils v1.10.1 (cached) * Community Tech Tree 1:3.4.5 (cached) * Kerbal Konstructs v1.8.8.0 (cached) * Kopernicus Expansion Continued-er Beta9.1.1 (cached) * KSP Community Fixes 1.35.2 (cached) * Near Future Electrical Core 2.0.1 (cached) * Singularity 0.991 (cached) * Space Dust 0.5.4 (cached) * Background Resources 1:v0.18.0.0 (cached) * Chatterer 0.9.99 (cached) * Cryogenic Engines 1:2.0.7 (cached) * Distant Object Enhancement /L v2.2.0.2 (cached) * Distant Object Enhancement /L default config v2.2.0.2 (cached) * Global Construction Core 2.7.1 (cached) * Kcalbeloh System v1.1.8 (cached) * Kcalbeloh System 8k Textures v1.1.8 (cached) * Kerbal Actuators v1.9.0 (cached) * Kerbal Atomics 1:1.3.4 (cached) * Konstruction v112.0.1 (cached) * Near Future Electrical 2.0.1 (cached) * Near Future Propulsion 1.3.6 (cached) * Near Future Solar 1.3.3 (cached) * Near Future Solar Core 1.3.3 (cached) * Near Future Spacecraft 1.4.5 (cached) * PlanetShine 0.2.6.6 (cached) * PlanetShine - Default configuration 0.2.6.6 (cached) * RasterPropMonitor Core 1:v1.0.2 (cached) * RemoteTech v1.9.12 (cached) * REPOSoftTech-Agencies V1.5.9.0 (cached) * Rocket Sound Enhancement 0.9.11 (cached) * SCANsat v20.4 (cached) * Staged Animation v2.0 (cached) * Stockalike Station Parts Expansion Redux 2.0.11 (cached) * AlphaMensae's Modular Launch Pads 2.7.0 (cached) * Astrogator v1.0.2 (cached) * Better Early Tree 1.0.2 (cached) * BetterBurnTime 1.10 (cached) * BetterTimeWarpContinued 2.3.13 (cached) * Chatterer Extended 0.6.2 (cached) * Community Parts Titles 0.10.3 (cached) * Community Parts Titles Extras: Categories 0.10.3 (cached) * Community Parts Titles Extras: CCK - No Duplicates 0.10.3 (cached) * Contract Pack: Anomaly Surveyor 1.7.1 (cached) * Contract Pack: Bases and Stations Reborn 2:3.7.3.3 (cached) * Contract Pack: Clever Sats 1.4 (cached) * Contract Pack: Exploration Plus 2.0.1 (cached) * Contract Pack: Field Research 1.2.2 (cached) * Contract Pack: Kerbal Academy 1.1.10 (cached) * Contract Pack: Research Advancement Division 1.2.1 (cached) * Contract Pack: Tourism Expanded 1.0.2 (cached) * Contract Pack: Tourism Plus 1.5.2 (cached) * Cryogenic Engines - Near Future Aeronautics 2.0.7 (cached) * Custom Barn Kit 1.1.22.0 (cached) * DeepFreeze Continued... V0.31.0.0 (cached) * DMagic Orbital Science 1.4.3 (cached) * DMModuleScienceAnimateGeneric v0.23 (cached) * Docking Port Alignment Indicator 6.10.0.0 (cached) * Easy Vessel Switch (EVS) 2.3 (cached) * Environmental Visual Enhancements Redux 3:1.11.7.2 (cached) * Extraplanetary Launchpads 6.99.3.0 (archive.org, 16.1 MiB) * Far Future Technologies 1.4.1 (cached) * FreeIva 0.2.19.0 (cached) * Global Construction 2.7.1 (cached) * Heat Control 0.6.2 (cached) * Hide Empty Tech Tree Nodes 1.3.2 (cached) * Improved Tree Engine Placement v1.4.0 (cached) * JX2Antenna 2.0.5 (cached) * Kerbal Atomics - Other Mod Support 1.3.4 (cached) * Kerbal Attachment System 1.12 (cached) * Kerbal Inventory for All 1:1.2.2 (cached) * Kerbal Inventory System 1.29 (cached) * Kerbal Joint Reinforcement Continued v3.8.1.0 (cached) * Kerbal Planetary Base Systems v1.6.16 (cached) * Minor Planets Expansion 1.0.8 (cached) * Near Future Aeronautics 2.1.2 (cached) * Near Future Construction 1.3.3 (cached) * Near Future Electrical - Decaying RTGs 2.0.1 (cached) * Near Future Exploration 1.1.3 (cached) * Near Future Launch Vehicles 2.2.1 (cached) * Near Future Propulsion - Xenon Hall Effect Thrusters 1.3.6 (cached) * Near Future Spacecraft - LFO Engines 1.4.5 (cached) * Off-Shore Launch Platform 1.0 (cached) * Omega's Stockalike Structures: No Textures Required 0.0.12 (cached) * Outer Planets Mod - Parallax with Scatters v1.0.5 (cached) * 'Project Orion' Nuclear Pulse Engine v112.0.1 (cached) * QuackPack 1.2.0 (cached) * Rational Resources 3.0.2 (cached) * RemoteTech StockConfigs 1:1.0.2 (cached) * ReStock+ 1.5.0 (cached) * Reviva 1.0.0 (cached) * Rocket Sound Enhancement - Default 1.3.0 (cached) * ScienceAlert ReAlerted 1.9.20.4 (cached) * Shaddy v2.5 (cached) * Simple Adjustable Fairings - Plugin v1.12.0 (cached) * Simple Repaint 0.4.2 (cached) * Space Dust Unbound 1.0.2 (cached) * Speed Unit Annex 1.6.1 (cached) * StageRecovery 1.9.7 (cached) * Starship Launch Expansion 1:Beta_v0.5 (cached) * Stockalike Station Parts Expansion Redux - Internal Spaces 2.0.11 (cached) * StockSCANsat v1.02 (cached) * System Heat - Nuclear Engine Configuration 0.7.5 (cached) * System Heat - Nuclear Reactor Configuration 0.7.5 (cached) * System Heat - Resource Converter Configuration 0.7.5 (cached) * System Heat - Resource Harvester Configuration 0.7.5 (cached) * Textures Unlimited 1.6.1.27 (cached) * Through The Eyes of a Kerbal 2.0.4.4 (cached) * Trajectories v2.4.5.3 (cached) * Universal Storage II Finalized 4.0.1.3 (cached) * USI Asteroid Recycling Technologies 1:v112.0.1 (cached) * USI Exploration Pack v112.0.1 (cached) * USI Freight Transport Technologies v112.0.1 (cached) * USI Kolonization Systems (MKS/OKS) 1:v112.0.1 (cached) * USI Life Support v112.0.1 (cached) * installed-Auto KSP 2024.05.15.01.03.25 (metapackage) Downloading https://api.github.com/repos/Starstrider42/Custom-Asteroids-Extras/zipball/v1.2.0 ... Downloading https://archive.org/download/ExtraPlanetaryLaunchpads-6.99.3.0/A1FEDDFC-ExtraPlanetaryLaunchpads-6.99.3.0.zip ... Downloading https://archive.org/download/CustomAsteroids-Pops-OPM-Outer-v1.2.0/56A2F860-CustomAsteroids-Pops-OPM-Outer-v1.2.0.zip ... Downloading https://archive.org/download/CustomAsteroids-Pops-OPM-Reconfig-v1.2.0/56A2F860-CustomAsteroids-Pops-OPM-Reconfig-v1.2.0.zip ... About to install: * VertexColorMapEmissive 1.0.0 (cached) * ReStock 1.5.0 (cached) * VertexHeightOblateAdvanced 1.1.4 (cached) * Custom Asteroids (alternative OPM config) v1.2.0 (api.github.com, 8.9 KiB) * Custom Asteroids (Kuiper belt analog for OPM) v1.2.0 (api.github.com, 8.9 KiB) * Community Resource Pack v112.0.1 (cached) * ModularFlightIntegrator 1.2.10.0 (cached) * Kopernicus Planetary System Modifier 2:release-1.12.1-214 (cached) * Contract Configurator v2.11.0.0 (cached) * Dynamic Battery Storage 2:2.3.3.0 (cached) * USI Tools v112.0.1 (cached) * Deployable Engines Plugin 1.3.1 (cached) * System Heat 0.7.5 (cached) * Community Terrain Texture Pack 1:1.0.5 (cached) * Cryo Tanks 1.6.6 (cached) * Cryo Tanks Core 1.6.6 (cached) * Firespitter Core v7.17 (cached) * Community Category Kit v112.0.1 (cached) * Outer Planets Mod 2:2.2.11 (cached) * USI Core v112.0.1 (cached) * Custom Asteroids v1.9.0 (cached) * Custom Asteroids (inner stock system data) v1.9.0 (cached) * Custom Pre Launch Checks 1.8.1.1 (cached) * Near Future IVA Props 1:0.7.2 (cached) * Parallax 2.0.8 (cached) * Parallax - Stock Planet Textures 2.0.8 (cached) * Parallax - Stock Scatter Textures 2.0.8 (cached) * Vertex Mitchell-Netravali Filtered Heightmap 0.3 (cached) * AT Utils v1.10.1 (cached) * Community Tech Tree 1:3.4.5 (cached) * Kerbal Konstructs v1.8.8.0 (cached) * Kopernicus Expansion Continued-er Beta9.1.1 (cached) * KSP Community Fixes 1.35.2 (cached) * Near Future Electrical Core 2.0.1 (cached) * Singularity 0.991 (cached) * Space Dust 0.5.4 (cached) * Background Resources 1:v0.18.0.0 (cached) * Chatterer 0.9.99 (cached) * Cryogenic Engines 1:2.0.7 (cached) * Distant Object Enhancement /L v2.2.0.2 (cached) * Distant Object Enhancement /L default config v2.2.0.2 (cached) * Global Construction Core 2.7.1 (cached) * Kcalbeloh System v1.1.8 (cached) * Kcalbeloh System 8k Textures v1.1.8 (cached) * Kerbal Actuators v1.9.0 (cached) * Kerbal Atomics 1:1.3.4 (cached) * Konstruction v112.0.1 (cached) * Near Future Electrical 2.0.1 (cached) * Near Future Propulsion 1.3.6 (cached) * Near Future Solar 1.3.3 (cached) * Near Future Solar Core 1.3.3 (cached) * Near Future Spacecraft 1.4.5 (cached) * PlanetShine 0.2.6.6 (cached) * PlanetShine - Default configuration 0.2.6.6 (cached) * RasterPropMonitor Core 1:v1.0.2 (cached) * RemoteTech v1.9.12 (cached) * REPOSoftTech-Agencies V1.5.9.0 (cached) * Rocket Sound Enhancement 0.9.11 (cached) * SCANsat v20.4 (cached) * Staged Animation v2.0 (cached) * Stockalike Station Parts Expansion Redux 2.0.11 (cached) * AlphaMensae's Modular Launch Pads 2.7.0 (cached) * Astrogator v1.0.2 (cached) * Better Early Tree 1.0.2 (cached) * BetterBurnTime 1.10 (cached) * BetterTimeWarpContinued 2.3.13 (cached) * Chatterer Extended 0.6.2 (cached) * Community Parts Titles 0.10.3 (cached) * Community Parts Titles Extras: Categories 0.10.3 (cached) * Community Parts Titles Extras: CCK - No Duplicates 0.10.3 (cached) * Contract Pack: Anomaly Surveyor 1.7.1 (cached) * Contract Pack: Bases and Stations Reborn 2:3.7.3.3 (cached) * Contract Pack: Clever Sats 1.4 (cached) * Contract Pack: Exploration Plus 2.0.1 (cached) * Contract Pack: Field Research 1.2.2 (cached) * Contract Pack: Kerbal Academy 1.1.10 (cached) * Contract Pack: Research Advancement Division 1.2.1 (cached) * Contract Pack: Tourism Expanded 1.0.2 (cached) * Contract Pack: Tourism Plus 1.5.2 (cached) * Cryogenic Engines - Near Future Aeronautics 2.0.7 (cached) * Custom Barn Kit 1.1.22.0 (cached) * DeepFreeze Continued... V0.31.0.0 (cached) * DMagic Orbital Science 1.4.3 (cached) * DMModuleScienceAnimateGeneric v0.23 (cached) * Docking Port Alignment Indicator 6.10.0.0 (cached) * Easy Vessel Switch (EVS) 2.3 (cached) * Environmental Visual Enhancements Redux 3:1.11.7.2 (cached) * Extraplanetary Launchpads 6.99.3.0 (archive.org, 16.1 MiB) * Far Future Technologies 1.4.1 (cached) * FreeIva 0.2.19.0 (cached) * Global Construction 2.7.1 (cached) * Heat Control 0.6.2 (cached) * Hide Empty Tech Tree Nodes 1.3.2 (cached) * Improved Tree Engine Placement v1.4.0 (cached) * JX2Antenna 2.0.5 (cached) * Kerbal Atomics - Other Mod Support 1.3.4 (cached) * Kerbal Attachment System 1.12 (cached) * Kerbal Inventory for All 1:1.2.2 (cached) * Kerbal Inventory System 1.29 (cached) * Kerbal Joint Reinforcement Continued v3.8.1.0 (cached) * Kerbal Planetary Base Systems v1.6.16 (cached) * Minor Planets Expansion 1.0.8 (cached) * Near Future Aeronautics 2.1.2 (cached) * Near Future Construction 1.3.3 (cached) * Near Future Electrical - Decaying RTGs 2.0.1 (cached) * Near Future Exploration 1.1.3 (cached) * Near Future Launch Vehicles 2.2.1 (cached) * Near Future Propulsion - Xenon Hall Effect Thrusters 1.3.6 (cached) * Near Future Spacecraft - LFO Engines 1.4.5 (cached) * Off-Shore Launch Platform 1.0 (cached) * Omega's Stockalike Structures: No Textures Required 0.0.12 (cached) * Outer Planets Mod - Parallax with Scatters v1.0.5 (cached) * 'Project Orion' Nuclear Pulse Engine v112.0.1 (cached) * QuackPack 1.2.0 (cached) * Rational Resources 3.0.2 (cached) * RemoteTech StockConfigs 1:1.0.2 (cached) * ReStock+ 1.5.0 (cached) * Reviva 1.0.0 (cached) * Rocket Sound Enhancement - Default 1.3.0 (cached) * ScienceAlert ReAlerted 1.9.20.4 (cached) * Shaddy v2.5 (cached) * Simple Adjustable Fairings - Plugin v1.12.0 (cached) * Simple Repaint 0.4.2 (cached) * Space Dust Unbound 1.0.2 (cached) * Speed Unit Annex 1.6.1 (cached) * StageRecovery 1.9.7 (cached) * Starship Launch Expansion 1:Beta_v0.5 (cached) * Stockalike Station Parts Expansion Redux - Internal Spaces 2.0.11 (cached) * StockSCANsat v1.02 (cached) * System Heat - Nuclear Engine Configuration 0.7.5 (cached) * System Heat - Nuclear Reactor Configuration 0.7.5 (cached) * System Heat - Resource Converter Configuration 0.7.5 (cached) * System Heat - Resource Harvester Configuration 0.7.5 (cached) * Textures Unlimited 1.6.1.27 (cached) * Through The Eyes of a Kerbal 2.0.4.4 (cached) * Trajectories v2.4.5.3 (cached) * Universal Storage II Finalized 4.0.1.3 (cached) * USI Asteroid Recycling Technologies 1:v112.0.1 (cached) * USI Exploration Pack v112.0.1 (cached) * USI Freight Transport Technologies v112.0.1 (cached) * USI Kolonization Systems (MKS/OKS) 1:v112.0.1 (cached) * USI Life Support v112.0.1 (cached) * installed-Auto KSP 2024.05.15.01.03.25 (metapackage) Downloading https://api.github.com/repos/Starstrider42/Custom-Asteroids-Extras/zipball/v1.2.0 ... Downloading https://archive.org/download/ExtraPlanetaryLaunchpads-6.99.3.0/A1FEDDFC-ExtraPlanetaryLaunchpads-6.99.3.0.zip ... Downloading https://archive.org/download/CustomAsteroids-Pops-OPM-Outer-v1.2.0/56A2F860-CustomAsteroids-Pops-OPM-Outer-v1.2.0.zip ... Downloading https://archive.org/download/CustomAsteroids-Pops-OPM-Reconfig-v1.2.0/56A2F860-CustomAsteroids-Pops-OPM-Reconfig-v1.2.0.zip ... ```
HebaruSan commented 6 days ago

The good news is that the Custom Asteroids mods are primarily hosted on GitHub and are only falling back to archive.org because of the braindead GitHub API change mentioned in #4192 to require the incorrect mime type application/vnd.github+json instead of the correct application/zip for source ZIPs. I should have the needed metadata update completed shortly...

HebaruSan commented 6 days ago

If you click Refresh in CKAN now, the Custom Asteroids mods should be able to download successfully.

ExtraPlanetaryLaunchpads is a different matter. With the original taniwha.org host distributing corrupted ZIPs and archive.org down, there is now no reliable download available for that mod. It's going to have to be removed from modpacks, or changed from depends to recommended as you noted.

RaynorD commented 6 days ago

Thanks, I got custom asteroids installed. Too bad about EPL.

My intent with the bug report was more targeting the skip option not working as expected, from my point of view anyways. If depends isn't going to allow us to skip files then it might be more clear not to offer skipping and show an error, if I'm understanding your intent.

Just my two cents though. Thanks for the quick response!

HebaruSan commented 6 days ago

Yeah, I've been looking into that part as well. When you click Skip, it should be removing EPL and the modpack from the changeset, but only EPL is being removed, and then it gets re-added as a dependency of the modpack on the retry. Don't know why yet...