KSP-CKAN / NetKAN-Infra

NetKAN Infrastructure Repo
MIT License
3 stars 6 forks source link

Fewer mods per GraphQL pass in DownloadCounter #316

Closed HebaruSan closed 1 year ago

HebaruSan commented 1 year ago

Problem

These have been getting more and more common lately:

image

A mod author asked about the download counts changing unexpectedly in another Discord.

Cause

The cause is impossible to identify with certainty because the error message is so absurdly, comically vague—"Something"? "this may be"??—but some reports online indicate that it may indeed be due to a timeout caused by too complex of a query, i.e. the amount of work we can do is arbitrarily limited per arbitrary bucket.

Changes

Now the download counter will send GraphQL requests for 20 mods at a time instead of 40. Since we don't and can't know what the problem is, it's impossible to guess whether this will change anything, but if the cause is in fact a timeout 🤞, then this should give our queries a bit more breathing room to finish before they are speculatively terminated by a possible time limit of unknown nature or even existence. (Never mind that the overall amount of work done is exactly the same, just split up into a greater number of smaller groups. 🙄)

Also the broken Coverage check is now disabled in this repo with an if: false condition because I got tired of seeing the error messages. We can turn it back on once it's working again.

techman83 commented 1 year ago

Thanks @HebaruSan - annoying that immediately after implementing that, it broke. I have work to do on some other projects, so I'll have a play around with it.

HebaruSan commented 1 year ago

Yeah, it's surprising how often things like that just break, given all the work that goes into making them work in the first place.

Maybe the easiest thing would be to start over and find a brand new coverage checker, rather than trying to fix this one?

techman83 commented 1 year ago

Well the coverage tool is fine, most of the projects use it to build reports from. It's just the reporting action that is a problem.