KSP-CKAN / NetKAN

Metadata files used by the NetKAN/CKAN indexer for KSP
Creative Commons Zero v1.0 Universal
72 stars 338 forks source link

TAC Life Support 11.2 doesn't have a ckan built #2830

Closed NathanKell closed 8 years ago

NathanKell commented 8 years ago

I don't see anything wrong offhand with the netkan, but there was no ckan built for the latest release.... (it's for 1.0.5, also, the first 1.0.5 build of TACLS)

https://github.com/taraniselsu/TacLifeSupport/releases

mheguy commented 8 years ago

You're right, there's nothing wrong with the netkan. It's pointing at KerbalStuff and the author hasn't released there.

mheguy commented 8 years ago

Using github as a kref will be problematic due to the .version file's compatibility listings:

  "KSP_VERSION": {
    "MAJOR": 1,
    "MINOR": 0,
    "PATCH": 5
  },
  "KSP_VERSION_MIN": {
    "MAJOR": 1,
    "MINOR": 0,
    "PATCH": 0
  },
  "KSP_VERSION_MAX": {
    "MAJOR": 1,
    "MINOR": -1,
    "PATCH": -1
  }
NathanKell commented 8 years ago

Ah, and the problem is it should only have the first block? (I definitely think we should retarget on github, though, for the record)

mheguy commented 8 years ago

I would love to target github, but I don't want to be responsible for manually changing ksp_version compatibility. If I used the mod or even played the game I would be more inclined, but that's not the case.

The issue is specifically the ksp_version_max' minor and patch versions being -1. It results in the metadata having ksp_version_min: 1.0.0 and ksp_version_max: 1. (ksp_version_max: 1 will cause issues).

NathanKell commented 8 years ago

Pinging @taraniselsu about this, or I can submit a PR to remove those blocks from the .version.

NathanKell commented 8 years ago

@plague006 I'm also making a temporary manual .ckan so at least it's on the client... https://github.com/KSP-CKAN/CKAN-meta/pull/899

NathanKell commented 8 years ago

After review by @Olympic1 we merged that in so people can play with TACLS meanwhile until this gets sorted out. :)

mheguy commented 8 years ago

:+1:

Olympic1 commented 8 years ago

Closing as a new update is released with a working .version file