KSP-CKAN / NetKAN

Metadata files used by the NetKAN/CKAN indexer for KSP
Creative Commons Zero v1.0 Universal
72 stars 340 forks source link

Tweak Scale shown for KSP 1.1 using old version 1.50. Strict max 1.0.5 with version 2.2.6 ? #3522

Closed solarsootysmudge closed 8 years ago

solarsootysmudge commented 8 years ago

Testing 1.1 pre release. Tweak Scale showing up as compatible using old version 1.50.

Max KSP version shown as 1.0.5 with version 2.2.6 which is correct. The mod should not being showing up for Ksp 1.1. It is a plugin that is not currently compatible. Is the this a case for setting ksp_version_strict for this particular mod given the Unity changes ?

mheguy commented 8 years ago

Is ... this a case for setting ksp_version_strict?

Nah, it's a case of https://github.com/KSP-CKAN/CKAN-meta/issues/623 (a ksp_version_min set without a ksp_version_max). https://github.com/KSP-CKAN/CKAN-meta/pull/1037 should fix this (if I caught all the versions of tweakscale that were affected).

Strict version compatibility is a narrow use-case when very small patches are released which breaks (nearly) no mods. In cases like that (as 1.0.4 to 1.0.5) we can set things up such that any mod compatible with 1.0.4 is compatible with 1.0.5 as well (unless the strict version flag is set). In the case of 1.1 it is not a small change, and no compatibility is assumed.