KSP-CKAN / NetKAN

Metadata files used by the NetKAN/CKAN indexer for KSP
Creative Commons Zero v1.0 Universal
71 stars 336 forks source link

[Bug]: SpaceY Extended/Heavy Lifters appears to install incorrectly #9913

Closed heyimastopsign closed 7 months ago

heyimastopsign commented 7 months ago

Is there an existing issue for this?

Operating System

MacOS

CKAN Version

1.34.2

Games

KSP 1

Game Version

1.12.5

Did you make any manual changes to your game folder (i.e., not via CKAN)?

No response

Describe the bug

Screenshot 2024-01-30 at 3 10 56 pm

A fair amount of SpaceY parts use the magenta placeholder texture instead of their proper ones.

Screenshot 2024-01-30 at 3 20 27 pm

Steps to reproduce

Relevant log output

No response

JonnyOThan commented 7 months ago

I'm pretty sure SpaceYExpanded references textures from SpaceY, and SpaceY has changed its directory structure at some point and SpaceYExpanded has not yet been updated. So this isn't really a metadata bug, unless we wanted to set a max version on the relationship from SpaceYExpanded.

Pinging @NecroBones and @zer0Kerbal to weigh in.

NecroBones commented 7 months ago

I'm pretty sure SpaceYExpanded references textures from SpaceY, and SpaceY has changed its directory structure at some point and SpaceYExpanded has not yet been updated. So this isn't really a metadata bug, unless we wanted to set a max version on the relationship from SpaceYExpanded.

I can't speak to how it's been modified, but yes that's correct-- SpaceYExpanded was designed as an extension and requires SpaceY to be installed for the textures.

Lisias commented 7 months ago

I think the following ~issue~ Pull Request is related to this problem:

https://github.com/KSP-CKAN/NetKAN/pull/9533

linuxgurugamer commented 7 months ago

@zer0Kerbal totally reorganized this mod for his own reasons. Until he fixes SpaceYExpanded, there isn't anything that CKAN can do to fix this

Lisias commented 7 months ago

@zer0Kerbal totally reorganized this mod for his own reasons. Until he fixes SpaceYExpanded, there isn't anything that CKAN can do to fix this

AFAIK, SpaceYExpanded is fixed - but CKAN choose not to index it. See #9533

Lisias commented 7 months ago

On a (more or less, it's my dev install) clean KSP 1.12.5 installment, I installed the most recent versions of:

fired the thing up, and then tried to reproduce the problem mentioned by @heyimastopsign :

screenshot61

It's working for me - but nothing on this rig was installed using CKAN.

JonnyOThan commented 7 months ago

@zer0Kerbal totally reorganized this mod for his own reasons. Until he fixes SpaceYExpanded, there isn't anything that CKAN can do to fix this

AFAIK, SpaceYExpanded is fixed - but CKAN choose not to index it. See #9533

Actually it IS indexed from spacedock, however it was frozen 4 years ago because of inactivity. PR #9533 is actually not the correct change, but we can get this unfrozen so that the more recent and future versions will be available on ckan.

JonnyOThan commented 7 months ago

Working on this here: https://github.com/KSP-CKAN/NetKAN/pull/9914

JonnyOThan commented 7 months ago

And done! Any further updates can be submitted as PRs to this file: https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/SpaceY-Expanded.netkan

linuxgurugamer commented 7 months ago

My understanding was that @zer0Kerbal was working on updating both mods