search

KSP-CKAN / NetKAN

Metadata files used by the NetKAN/CKAN indexer for KSP
Creative Commons Zero v1.0 Universal
70 stars 337 forks source link

Fix gpp scatterer version #9956

Closed JonnyOThan closed 4 months ago

JonnyOThan commented 4 months ago

In #8880 and #8881 the scatterer version for GPP was set, but it incorrectly allowed scatterer 0.0852 to be installed.

HebaruSan commented 4 months ago

Is it actually incorrect?

image

JonnyOThan commented 4 months ago

No. GPP is also not compatible with 0.0825. Since 0.0825 < 0.0825b, the previous conflict metadata allowed 0.0825 to be installed. Now the latest compatible version should be 0.0772 as indicated by the author.

HebaruSan commented 4 months ago

GPP is also not compatible with 0.0825

I guess I was hoping to learn the reason behind this claim, since the announcement by the author is ambiguous and doesn't address it.

JonnyOThan commented 4 months ago

Hard to say, but considering the 'b' designation and the fact that 0.0852b was released a day after 0.0852, I'm guessing that the GPP authors were merely referencing the most recent publicly available build of scatterer which was not compatible.

This came to my attention because someone on discord installed GPP and scatterer (0.0852) with CKAN and it did not work properly. 0.0772 did.

JonnyOThan commented 4 months ago

Oh shoot do we also need to go edit the historical versions according to the comment in 8880?

JonnyOThan commented 4 months ago

Hm I tried installing latest scatterer and then GPP, and it correctly flagged the conflict. I also tried installing scatterer 0.0852b and then GPP, and it was also marked as conflict. Maybe installing older versions of GPP would be allowed but it seems like the common pathways are correct at least.