search

KSP-CKAN / NetKAN

Metadata files used by the NetKAN/CKAN indexer for KSP
Creative Commons Zero v1.0 Universal
70 stars 337 forks source link

Declares a conflict with TweakScaleRescaled-Redist #9977

Closed Lisias closed 4 months ago

Lisias commented 4 months ago

TweakScaleRescaled-Redist is being offered as an option when installing TweakScale, whats a mistake - while I can guarantee compatibility with the current interfaces, I can't say the same for future new ones.

HebaruSan commented 4 months ago

@JonnyOThan, that's your mod. Does this look right to you?

JonnyOThan commented 4 months ago

@Lisias What are you trying to do here? TweakscaleRescaled-Redist already has a conflict with Tweakscale-redist so not sure why this is needed. Did you mean to declare a conflict between Tweakscale and tweakscaleRescaled-redist?

er, I’d assume “yes” because that’s what the PR description says, but that’s not what this change does.

I have no problem merging this PR but it doesn’t actually do anything so I’m trying to figure out what you intended.

Lisias commented 4 months ago

When I installed TweakScale™ via CKAN, CKAN asked me if I wanted to install TweakScale-Redist or TweakScaleRescaled-Redist , what's an error.

If TweakScale is being installed, the only option available should be TweakScale-Redist, and it should not be installed without it, or using the alternative.

JonnyOThan commented 4 months ago

When I installed TweakScale™ via CKAN, CKAN asked me if I wanted to install TweakScale-Redist or TweakScaleRescaled-Redist , what's an error.

If TweakScale is being installed, the only option available should be TweakScale-Redist, and it should not be installed without it, or using the alternative.

That makes sense, but this PR doesn't do that. You would need to declare that TweakScale conflicts with TweakScaleRescaled-Redist.

JonnyOThan commented 4 months ago

By the way, having two versions of Tweakscale-redist does create a bit of a headache. What would you think about collaborating on that library so that there's only one version? Have you looked over the changes I made in tweakscalerescaled-redist?

Lisias commented 4 months ago

TweakScale 2.5 will introduce a new interface, with retro-compatibility. Merging the Redists will bring over us yet more headaches than we have nowadays.

I'm fixing the pull request.