Recent commits made user-facing changes without docs.

[Dunbaratu]

Commit 9758b0a ( https://github.com/KSP-KOS/KOS/commit/9758b0a5590807a16a2ae6c3413b9f2ee908c9a9#diff-90d61f0c4968e4051d3275a8de2f3157 )

was just merged and I noticed it adds a new feature that is not mentioned to the user or visible to them. I think it should be.

It adds the concept that some Collections we return can be read-only. Notably, the value returned by SHIP:PARTS is a LIST, which now has this readOnly flag turned on. This makes sense because you can't just physically alter the vessel's parts by having your script call SHIP:PARTS:ADD() or SHIP:PARTS:REMOVE().

But, I think this needs a mention in the user docs, along with a few other changes that just got committed to develop:

Doc changes needed

• Mention some collections are read-only now. Link to this documentation wherever a collection manipulation suffix is described in detail (ADD, REMOVE, CLEAR, etc). Also mention at the "implicit add" that happens when you assign to a new lex index (i.e. myLex["newKey"] = value.)
• New Suffix List:INDEXOF (also alias: List:FIND)
• New Suffix List:LASTINDEXOF (also alias: List:FINDLAST)
• New Suffix String:FORMAT
• New Suffix ElementValue:DECOUPLERS (also alias ElementValue:SEPARATORS)
• New Suffix EngineValue:POSSIBLETHRUST
• New Suffix EngineValue:POSSIBLETHRUSTAT
• New Suffix EngineValue:MAXPOSSIBLETHRUST
• New Suffix EngineValue:MAXPOSSIBLETHRUSTAT
• New Suffix Part:DECOUPLER (also alias: Part:SEPARATOR)
• New Suffix Part:DECOUPLEDIN (also alias: Part:SEPARATEDIN)
• New Suffix Vessel:DECOUPLERS (also alias: Vessel:SEPARATORS)
• Ability to issue the command list DECOUPLERS in myList.

A suffix to query if a collection is readonly

IMO it would also be good to let users query if a collection has that new "readonly" feature turned on, in a get suffix. It could also be a "set" suffix so users can make their own lists read-only if they like, but only if we enforce a rule that once a collection has become readonly, it cannot be set back to writable again (Otherwise we'd be letting people do set ship:parts:readonly to false. undermining the point of making it readonly. It has to be that once the readonly flag is on, it stays on.)

[hvacengi]

I missed some of this because it was added after I started my initial review. Here is a list of things I've checked in the final merge of #2256

• [ ] New Suffix List:INDEXOF (also alias: List:FIND)
• [ ] New Suffix List:LASTINDEXOF (also alias: List:FINDLAST)
• [ ] New Suffix String:FORMAT
• [ ] New Suffix ElementValue:DECOUPLERS (also alias ElementValue:SEPARATORS)
• [x] New Suffix EngineValue:POSSIBLETHRUST
• [x] New Suffix EngineValue:POSSIBLETHRUSTAT
• [ ] New Suffix EngineValue:MAXPOSSIBLETHRUST
• [ ] New Suffix EngineValue:MAXPOSSIBLETHRUSTAT
• [x] New Suffix Part:DECOUPLER (also alias: Part:SEPARATOR)
• [x] New Suffix Part:DECOUPLEDIN (also alias: Part:SEPARATEDIN)
• [x] New Suffix Vessel:DECOUPLERS (also alias: Vessel:SEPARATORS)
• [ ] Ability to issue the command list DECOUPLERS in myList.
• [ ] Add new suffix for readonly state of collections

I will attempt to provide the documentation for the incomplete items before the final push to upstream.