search

KSP-KOS / KOS

Fully programmable autopilot mod for KSP. Originally By Nivekk
Other
698 stars 230 forks source link

ENGINE:VISP should return design vacuum ISP of the engine #273

Closed pdbogen closed 9 years ago

pdbogen commented 10 years ago

Ideally we'd have: ENGINE:ISP:VACUUM ENGINE:ISP:ATMOSPHERE ENGINE:ISP:CURRENT

But I'm not sure if that would break compatibility with scripts expecting ENGINE:ISP to just be a number.

Dunbaratu commented 10 years ago

It would break backward compatibility. In this case I don't think there is a good case for a separate ISP object because all it is is a plain scalar number. Having 3 different ISP's as flat numbers makes sense because they are indeed 3 different things.

Unlike, say, velocity, where Velocity:orbit and Velocity:surface are actually just two different ways to express the same exact thing - in two different frames of reference (come to think of it, we could also have a Velocity:target).

pdbogen commented 10 years ago

Works for me. P.S., VELOCITY:TARGET would save me a lot of LOCK RVEL TO VELOCITY:ORBIT - TARGET:VELOCITY:ORBIT.

On October 14, 2014 9:37:59 PM PDT, Steven Mading notifications@github.com wrote:

It would break backward compatibility. In this case I don't think there is a good case for a separate ISP object because all it is is a plain scalar number. Having 3 different ISP's as flat numbers makes sense because they are indeed 3 different things.

Unlike, say, velocity, where Velocity:orbit and Velocity:surface are actually just two different ways to express the same exact thing - in two different frames of reference (come to think of it, we could also have a Velocity:target).

Reply to this email directly or view it on GitHub: https://github.com/KSP-KOS/KOS/issues/273#issuecomment-59156763

  • Patrick
erendrake commented 10 years ago

Question, what are you trying to do with these values?

pdbogen commented 10 years ago

For ENGINE:VISP, my intent was to calculate an upper bound for available DeltaV.

On October 14, 2014 11:57:23 PM PDT, Chris Woerz notifications@github.com wrote:

Question, what are you trying to do with these values?

Reply to this email directly or view it on GitHub: https://github.com/KSP-KOS/KOS/issues/273#issuecomment-59165193

  • Patrick