KSP-KOS / KOS

Fully programmable autopilot mod for KSP. Originally By Nivekk
Other
693 stars 229 forks source link

screwy textfield input in CONFIG part of applauncher panel #565

Closed Dunbaratu closed 9 years ago

Dunbaratu commented 9 years ago

RIght now, when a CONFIG field is a non-boolean (so you have a type-in blank), the user interface for it is really screwy and nearly impossible to use. At the moment the only such field is the CONFIG:IPU, but with the new telnet update, the CONFIG:TPORT also uses the same interface, and it really needs fixing.

The problem: Instead of waiting for you to commit your edits before checking if the field is sensible, it tests the value after each and every single keypress change.

So lets say you start with the CONFIG:IPU value: 1000 and want to change it to '400'. If you try to do it by just deleting the "10" and replacing it with "4" you can't do it. Because this happens:

  1. Put cursor here: 10|00
  2. Hit backspace once: Your new value is temporarily 100, which is below the minimum of 150, so it changes it to 150 "for you" before you have a chance to hit the second "backspace" and type in a 4.

Okay so try it this way:

  1. Put cursor here: |1000, intending to delete to the right.
  2. Press del> once. Your new temporary value is 000, which is below the minimum so it changes it to 150.

And so on. The only way to change it is to find a weird convoluted way to change it such that all inbetween values while typing are themselves legal.

That needs to be fixed before the telnet update goes out. The same problem happens on setting the TPORT and it's annoying.

Dunbaratu commented 9 years ago

Paired with PR # 566 - close it after 566 is pulled.