search

KSP-KOS / KSLib

The standard library and examples for the Kerboscript language
MIT License
120 stars 40 forks source link

Lib_list_dialog rework #49

Closed abenkovskii closed 9 years ago

abenkovskii commented 9 years ago

Proof of concept in done. But don't merge before I improve it and write a documentation. issue: #41

abenkovskii commented 9 years ago

@akrasuski1 Could you check this out please?

akrasuski1 commented 9 years ago

Checking.

akrasuski1 commented 9 years ago

Bug: when the list is exactly two full pages long, the cancellable dialog shows: page 2/2, but you can go to the third page (then it says page 3/2 and contains just the next, previous and cancel buttons). Other than that, I haven't found bugs.

akrasuski1 commented 9 years ago

Cosmetic changes I would adopt:

  1. The controls could be capitalized (i.e. Next page, Previous page, Cancel). The word Page too.
  2. The example has a typo: it's choose, not chose. Also add a colon (:) at the end of the title (in example, not the library)
  3. This is discutable: the page 2/2 thing in the current place looks as part of the title. I would either move it to the top of the screen, or skip the word page, leaving it to be just 2/2. Any other ideas?
abenkovskii commented 9 years ago

Done.

abenkovskii commented 9 years ago

Documentation for it: #54, #55

abenkovskii commented 9 years ago

@akrasuski1 Could you please check this out?

akrasuski1 commented 9 years ago

inaccessibe_lines variable is misspelled - should be inaccessible_lines. No other problems, you can merge it.