Make popup messages easier to understand, fix checkout on Windows

[HebaruSan]

Hi @Lisias,

A user posted this on the forum, and I saw some opportunities to improve it:

Once I took a look at the TweakScale repo, I found several other similar messages there and in the KSPe repo. Attached are my attempts to make them easier to understand.

Visible:

• Standard English capitalization of proper nouns and beginnings of sentences only
• Non-idiomatic wording like "best line of action" replaced by more standard phrases
• "Did not X" for a verb X should be in present tense ("find"), not past tense ("found")
• Technical language simplified to focus on what the user needs to know and do to handle the problem
• Commas between independent clauses changed to semicolons

Technical:

• A const string is preferable to a static readonly string for a private value

net-lisias-ksp/TweakScale#265 is making some additional related changes.

Cheers!

Side fixes

While setting up to work on this, I noticed that cloning this repo fails on Windows because some of the filenames contain pipes, so I've also replaced those pipes with dashes.

$ git clone https://github.com/net-lisias-ksp/KSPe.git
Cloning into 'KSPe'...
remote: Enumerating objects: 6984, done.
remote: Counting objects: 100% (675/675), done.
remote: Compressing objects: 100% (216/216), done.
remote: Total 6984 (delta 489), reused 617 (delta 450), pack-reused 6309
Receiving objects: 100% (6984/6984), 14.34 MiB | 1.93 MiB/s, done.
Resolving deltas: 100% (4731/4731), done.
error: invalid path 'Docs/RecomendedReadings/Native interoperability best practices - .NET | Microsoft Docs.pdf'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Note that only the local/TweakScale branch is updated, because it's the most relevant to the screenshot above. I'll make another pull request for the main branch after this.

[Lisias]

Hi! It took me a hell of a time, but I'm finally looking into it.

The pull request will be merged, but the changes from static readonly to const will be revered due the following reasons:

• It will break the ABI and, so, any code relying on Reflection to hack it.
  • Localisation is not exactly an afterthought on KSPe, but I should had implemeneted about it sooner. But things are how they are, the path of less friction by now is to keep using static readonly on everything
  • Spoiler : the static readonly string var = "blah"; will be replaced (eventually) to static readonly string var = GetLocalizationString("SOME_MEANINGFUL_ID");
    • The Localization will be implemented using the KSP's current mechanism using Config Files.
• Mixing const and static readonly on the same code is generally a bad idea, and most of the code relies on static readonly being ir private, protected or public.

Thanks for you time on it!