KSP-RO / Kerbal-Joint-Reinforcement-Continued

Physics stabilizer plugin for Kerbal Space Program
GNU General Public License v3.0
36 stars 14 forks source link

Update for KSP 1.7.x #2

Closed siimav closed 5 years ago

siimav commented 5 years ago

Works with KSP versions starting from 1.4.0.

raidernick commented 5 years ago

Can somebody else test to to confirm that it's actually working. I tried it in ksp 1.3.1 and I'm getting floppy noodle rockets. @pap1723

siimav commented 5 years ago

After the latest Starwaster's changes it no longer even builds on KSP 1.3.1. I used KSP 1.4.5 for putting the updated dll together. @pap1723 Please drop that into your 1.6 install the next time you fire it up.

PhineasFreak commented 5 years ago

If the "skipGroundPositioning" parameter is not critical then it may be possible to omit it and allow full KSP 1.3-1.7 compatibility.

siimav commented 5 years ago

@PhineasFreak that's true - I'm quite sure that it would work correctly from 1.3 all the way to 1.7. Do you think supporting 1.3.x would be useful?

PhineasFreak commented 5 years ago

That depends. If RP gets another KSP 1.3.1 release then it should be supported, otherwise there is no reason.

siimav commented 5 years ago

A traditional CKAN release looks a bit unlikely because of all the backports and forks that are needed to set that up. If RP-1 does get an official update for 1.3.1 then I think @pap1723 intends to do that in the modpack form in which case we could manually build a different version of KJR to make it compatible with 1.3.1.

pap1723 commented 5 years ago

@PhineasFreak yeah, I looked into it a little, while I don't know if that parameter is entirely crucial, it VERY much helps to stabilize and stop the "jumping" craft on reload. We are going to have to play a lot of games to get a good release for 1.3.1 again, so we will add this to the list of things to change.