search

KSP-RO / KerbalRenamer

BSD 2-Clause "Simplified" License
8 stars 12 forks source link

added setting options to the New Game menu + original 4 re-rolled without going to astronaut ctr #5

Closed AndreMessier closed 6 years ago

AndreMessier commented 6 years ago

I've made a few updates to the Kerbal Renamer. The previous version wouldn't rename/reroll the original 4 until you went into the Astronaut building. Now they get renamed when the new game is created.

I also moved the config settings into the new game menu. I'm still debating keeping the values in the cfg file in case this mod is installed to an in-progress game.

Unfortunately, I seem to have broken the Icon Changer functionality... That may just be a 1.3.1 thing though as that is what I'm building against and I didn't verify that it was still working before I started making changes

AndreMessier commented 6 years ago

I don't disagree with any of the changes you are suggesting but none of that is my code. I copy/pasted some of the classes out into their own files but left most of the code unchanged. I'll try to get some of those changes implemented soon.

rsparkyc commented 6 years ago

Sorry I'm slow on this, have a lot going on IRL now. I guess when you moved some code around, it made it look like it was new instead of just moved, so that's why I assumed it was new stuff. I may go through and see if I can clean it up a bit too. Thank's for putting some work into this.

AndreMessier commented 6 years ago

No worries. Glad I can help. I'm tempted to break things up a bit further and make each class live in a file named after the class. Not sure what I was thinking when I made the Settings.cs file since it doesn't contain a class named "Settings"...

rsparkyc commented 6 years ago

Have at it :)

NathanKell commented 6 years ago

Yay settings! :)

rsparkyc commented 6 years ago

I'm going to work on merging in all these PRs, they've all seemed to be set up to work with 1.4.x. I'm also going to remove the binaries from this solution, and work on just having those be in the releases. Should clean this project up a bit :)

rsparkyc commented 6 years ago

Ok, just loaded up the game. The new settings look awesome! I noticed that the "preserve original 4" option works great, however when I was testing in sandbox mode, all the Kerbals I could hire still had the last name of "Kerman".