search

KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
71 stars 79 forks source link

My fuel tanks just... fall off.. my craft just.. falls apart. #105

Closed jonassm closed 5 years ago

jonassm commented 9 years ago

Nothing is really leading up to this.. it just happens. Playing on RO.

OtherBarry commented 9 years ago

Did you clip any of them?

jonassm commented 9 years ago

Nope.. pretty certain. This only happens when i make bigger rockets.

Less, ofc, let's say i make a cone with fuel that goes from 2M to 3M, then a fuel tank thats directly placed on the bottom node of that cone, then yes, im clipping.

OtherBarry commented 9 years ago

As in you mean you attach top node of tank to bottom node of cone (or vica versa)?

On Mon, Jan 26, 2015 at 11:05 PM, Jonassm notifications@github.com wrote:

Nope.. pretty certain. This only happens when i make bigger rockets.

Less, ofc, let's say i make a cone with fuel that goes from 2M to 3M, then a fuel tank thats directly placed on the bottom node of that cone, then yes, im clipping.

Date: Mon, 26 Jan 2015 03:55:38 -0800 From: notifications@github.com To: ProceduralParts@noreply.github.com CC: jonas-morbjerg@live.dk Subject: Re: [ProceduralParts] My fuel tanks just... fall off.. my craft just.. falls apart. (#105)

Did you clip any of them?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/Swamp-Ig/ProceduralParts/issues/105#issuecomment-71451261 .

jonassm commented 9 years ago

like this http://i.imgur.com/04K8Dmk.png

OtherBarry commented 9 years ago

Yeah, very odd. Cones are screwing things up it seems. As a suggestion, try using smooth cones, there should be a 'straight' option, so it'll effectively be a cone. Hopefully that'll fix it.

ItMustBeACamel commented 9 years ago

I can not reproduce the issue...any more infos? Does it always appear in that configuration you describe in your drawing? Or only sporadic?

jonassm commented 9 years ago

I guess i would say more with bigger rockets.

MagiMaster commented 9 years ago

I'm having the same problem: http://youtu.be/aR1clqK7owk

I noticed this in my log file: [EXC 15:41:40.221] NullReferenceException: Object reference not set to an instance of an object ProceduralParts.ProceduralPart.AddPartAttachment (Vector3 position, ProceduralParts.Transformable target, Boolean normalized) ProceduralParts.ProceduralPart.PartChildAttached (.Part child) System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation. System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) KSPAPIExtensions.PartMessage.ServiceImpl.Send (KSPAPIExtensions.PartMessage.CurrentEventInfoImpl message) KSPAPIExtensions.PartMessage.ServiceImpl.Update () UnityEngine.Debug:LogException(Exception) KSPAPIExtensions.PartMessage.ServiceImpl:Update()

(I'm getting different NullReferenceExceptions with procedural parts uninstalled, so it might not be the root cause, although my rockets do stop falling apart.)

ItMustBeACamel commented 9 years ago

@MagiMaster Thanks for the report. Can you please send me the whole logfile at radarmanfromthemoon@gmail.com?

ItMustBeACamel commented 9 years ago

@MagiMaster Just had a look on your logfile and there are a lot of NREs related to RealFuels while in flight mode.

[EXC 17:45:06.447] NullReferenceException: Object reference not set to an instance of an object RealFuels.ModuleEngineConfigs.SetThrust () RealFuels.ModuleEngineConfigs.FixedUpdate ()

I think this might actually be a RealFuels issue that somehow affects ProceduralParts.

NathanKell commented 9 years ago

If it's RF (and thus My Fault (tm) ) can you upload the logs so I can get 'em too? Note: output_log.txt (win) or player.log (osx/nix), not KSP.log (useless). Thanks!

MagiMaster commented 9 years ago

Here's a copy of the output_log.txt and a craft file that demonstrates the problem.

Date: Wed, 11 Feb 2015 23:46:16 -0800 From: notifications@github.com To: ProceduralParts@noreply.github.com CC: archmageomega@hotmail.com Subject: Re: [ProceduralParts] My fuel tanks just... fall off.. my craft just.. falls apart. (#105)

If it's RF (and thus My Fault (tm) ) can you upload the logs so I can get 'em too? Note: output_log.txt (win) or player.log (osx/nix), not KSP.log (useless). Thanks!

— Reply to this email directly or view it on GitHub.

MagiMaster commented 9 years ago

Well, I sent that reply through my email, but I'm not quite sure the attachment went through, so here it is again: https://dl.dropboxusercontent.com/u/29146569/Kerbal_Log.rar

ItMustBeACamel commented 9 years ago

@NathanKell I can reproduce the issue, but only with the ion engines. They are throwing NREs in Flight Mode even when there are no PP tanks involved. Seems like RealFuels can not properly find the ModuleEngines module on these.

NathanKell commented 9 years ago

What engine configs were used? RO's? Stockalikes?

ItMustBeACamel commented 9 years ago

@NathanKell RO. Installed via CKAN

NathanKell commented 9 years ago

Thanks! We'll look into it.