Proc parts not occluded - Occlusion data needs updating?

[NathanKell]

I have noticed an issue with proc parts during reentry where a proc part is not properly occluded.

Reproduction steps:

• Enter VAB
• Place an octo2
• Place a 1.25m heat shield below the octo2
• Place a proc tank above the octo2, shrink it down to be very small and very short such that it will obviously be occluded by the heatshield.
• Launch, hyperedit into a reentering orbit, orient so it's shield first, enter the atmosphere
• Turn on thermal data
• Right-click the tank and watch how All Skin changes to Exposed skin (or is already Exposed skin) even though no skin area on the tank should be exposed (due to occlusion from the shield).
• Assuming the reentry is violent enough, the tank should blow up.

What I guess may be going on is that, after you rebuild the drag cubes, you will need to rebuild the thermal graph. To do that, you probably need to fire a part or vessel event of some sort (maybe there's an innocuous one) or reflect into the vessel module of type (or derived from) FlightIntegrator and set recreateThermalGraph = true I believe that will solve the problem; if it doesn't, something else screwy is going on.

hattip to @stratochief66 who found this, I've just narrowed it down to what I think's going on. :)

[ItMustBeACamel]

I could not reproduce, but I made it so that onVesselModified gets fired after recalculating drag cubes. Would you please run a test with the new 1.1.10 release and see whether it helps?

[NathanKell]

Sure thing! Thanks.

[stratochief66]

I am still seeing it happen with 1.1.10 unfortunately, both with ProcTanks and with RealChutes. I am doing a bit more testing and I will post a craft file shortly.

[stratochief66]

https://www.dropbox.com/sh/xackguwx8id2m9k/AACRU86ozl86Jjz5ywIN0xDta?dl=0

[ItMustBeACamel]

There are quite a few modparts on your craft. Since I could not reproduce the issue on a PP only install, I assume it to be some kind of incompatibility. Would be great if youn could try to find out which one is causing trouble. A list of mods you are using might also be useful.

[NathanKell]

If it's the same as before, the mod parts are the RealChute radial parachutes and a quartet of 1/4-scaled RCS thrusters and a 1m heatshield (rescaled from how it was). @stratochief66 I think we should try to repro with just stock + PP + FAR, as that should be openable by anyone.

[ItMustBeACamel]

Seems like FAR is the problem. (could reproduce) Not that surprising since PP does not update DragCubes at all if FAR is installed.

[NathanKell]

Oh! That would explain things. You definitely still need to update them. You'll break thermo and buoyancy otherwise.

[ItMustBeACamel]

Alright. So I guess they are not just drag cubes :D Is there any reason to update them while in editor? because people will complain about performance and FAR will need the voxelstuff for its graphs.

[NathanKell]

I would do it under a setting in the MODULE, maybe, because it's possible other mods (like, something that calculated buoyancy in the editor) would need it to be on, but it should default to off.

[ItMustBeACamel]

Good idea. Tests are good so far. I'm about to issue a hotfix.

[NathanKell]

<3