KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
71 stars 79 forks source link

Use module TankContentSwitcher for non PP parts #188

Closed mossarelli closed 4 years ago

mossarelli commented 8 years ago

According to the comments in TankContentSwitcher.cs: /// One can set this module up on any existing fuel part (Maybe with module manager if you like) /// if you set the volume property in the config file.

I've looked at the 1TankLiquid.cfg and copied the following volume properties: Module Techlimit: diameterMin, diameterMax, lengthMin, lengthMax, volumeMin, volumeMax

I have tried unitsPerT, amount, maxAmount in the module TankContentSwitcher with both useVolume = true and false.

I'm trying to convert the mk3FuselageLFO_25 to use the TankContentSwitcher so I can use more fuel types. So far I've managed to get the part to display the correct volume in game but the fuel containers does not work and switching fuel type makes the game bug out.

Picture related: fuel tank

Please provide a bare minimum template for all the info that the module needs in order to function.

Polymaker commented 8 years ago

The TankContentSwitcher module has multiples references to its ProceduralPart without null checks, so if you want to make it work the class must be altered. I had a quick look and TankContentSwitcher does not seem to require Techlimit node in the config file. It just access the Volume property of its part.