search

KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
71 stars 79 forks source link

No lower limit on SRB Burn time #202

Closed newaccountistempodat closed 5 years ago

newaccountistempodat commented 8 years ago

There is no lower limit on the srb burn time. The maximum time is 600 seconds, but the minimum is 0, and the nozzle gets ridiculously large.

echoAwoo commented 8 years ago

If you allow the SRB burn time to hit 0, you must either delete and readd the part or reload the vessel, otherwise the game ends with a 0 in the denominator that never changes. Vessel price literally goes to infinity.

I suppose I should phrase this better.

Procedural Parts w/ Real Fuels first SRB, the Procedural Real Fuels SRB, Career mode if burn time hits 0 while in the VAB, vessel cost climbs to infinity. It locks at this point instead of updating if you change any of the corresponding values.

This also creates a lower limit of 60s on an SRB for burn time.

ntwest commented 8 years ago

I believe this is related to the error I get with the procedural SRB.

ArgumentException: Illegal prefix

Parameter name: pfx at KSPAPIExtensions.MathUtils.PrefixString (SIPrefix pfx) [0x00000] in :0

at KSPAPIExtensions.MathUtils.FormatSI (SIPrefix pfx, Double value, Int32 sigFigs, Int32 exponent, System.String unit) [0x00000] in :0

at KSPAPIExtensions.MathUtils.ToStringSI (Single value, Int32 sigFigs, Int32 exponent, System.String unit) [0x00000] in :0

at ProceduralParts.ProceduralSRB.UpdateThrustDependentCalcs () [0x00000] in :0

at ProceduralParts.ProceduralSRB.UpdateThrust (Boolean force) [0x00000] in :0

at ProceduralParts.ProceduralSRB.OnUpdateEditor () [0x00000] in :0 UnityEngine.Debug:Internal_LogException(Exception, Object) UnityEngine.Debug:LogException(Exception) ProceduralParts.ProceduralSRB:OnUpdateEditor() ProceduralParts.ProceduralSRB:Update()

rsparkyc commented 7 years ago

Should be fixed in this version: https://github.com/Starwaster/ProceduralParts/releases/tag/v1.2.10