search

KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
71 stars 79 forks source link

Procedural tanks disappearing with revert to launch #258

Closed kendoka15 closed 4 years ago

kendoka15 commented 4 years ago

When I revert to launch with a simple craft, the procedural liquid tank disappears yet the engine below and pod on top are still connected. Steps to reproduce:

  1. Launch clean KSP install with Procedural Parts 2.0.1
  2. Make new sandbox save with defaults
  3. Make simple craft in VAB consisting of Mk1 pod, procedural liquid tank and LV-909 engine.
  4. Launch it
  5. Revert to launch, fuel tank is gone: https://imgur.com/a/GUWCaBH

Log up to that moment: k1.txt

BarringtonP commented 4 years ago

Had the same problem. Interestingly the main body of a procedural SRB disappears but the nozzle remains.

Rolling back to the previous version seems to have fixed it.

Not sure if it's the same problem but I first encountered it after updating procedural parts. With larger or more complex craft the entire craft seems to disappear completely on switching to another craft and back. Altitude reads all red zeroes. On switching to another craft in flight more textures would seem to be missing/black. After reverting to launch the KSC would be missing. This would be followed by a crash back to the windows desktop. Continued to have this issue after a clean install (with plenty of other mods...) and encountered the "tanks dissapearing" issue while trying to duplicate it.

DRVeyl commented 4 years ago

That's certainly irritating. Does look like the previous version does not have the issue. Was able to reproduce, thanks. Will dig into it.

DRVeyl commented 4 years ago

Fixed in https://github.com/KSP-RO/ProceduralParts/commit/4b908ad66fd85c344c2c17a787c81c4db31e4260 and released with https://github.com/KSP-RO/ProceduralParts/releases/tag/v2.0.2

Please update immediately. Do not cause any vessels to be saved with the v2.0.1 release; the bug causes the part to resize to minimums, and if the vessel gets saved, it will retain that new size.

kendoka15 commented 4 years ago

This issue is indeed fixed although the tanks not filling up with resizes bug was brought back (this one)