KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
71 stars 79 forks source link

Texture tiling not respecting uScale & autoHeightSteps #263

Closed Entropy2016 closed 4 years ago

Entropy2016 commented 4 years ago

It's my understanding that autoHeightSteps is meant to make the texture tile/repeat vertically rather than getting stretched across the entire side of the part. But that doesn't appear to be happening. For example, the "Ablative" texture config:

Ablative
{
    // by e-dog
    sides
    {
        texture = ProceduralParts/Parts/ablative
        uScale = 2
        vScale = 1
        autoScale = true
        autoHeightSteps = 1
        shininess = 0.2
        specular = 0.2, 0.2, 0.2
    }
    ends
    {
        texture = ProceduralParts/Parts/stockend
    }
}

Screen Shot 2020-05-30 at 4 52 55 PM

I've also noticed texture's having scaling issues horizontally as well. (Note this example is from a custom texture pack. I believe the texture should tile 4 times horizontally if uScale = 4, but it's currently rendered as just 1 tile stretched across the entire cylinder's circumference.

Destiny
{
    //by JebediahKerman42 aka Freedom
    sides
    {
        texture = FreedomTex/Destiny
        bump = FreedomTex/destiny_NRM
        uScale = 4
        vScale = 1
        shininess = 0.8
        autoScale = true
        specular = 0.8, 0.8, 1
        autoHeightSteps = 1
    }
    ends
    {
        texture = ProceduralParts/Parts/ends
    }
}

Screen Shot 2020-05-30 at 4 38 44 PM

Yet the tiling used to look more like this: https://i.imgur.com/fRIdY0t.png

DRVeyl commented 4 years ago

Thank you. I see where ProcParts stopped listening for its own notification that it needed to update the scale. Will get this into a patch.

DRVeyl commented 4 years ago

Fixed in https://github.com/KSP-RO/ProceduralParts/commit/3466a39b62929bcca81d1b3b07788f8134be0ce7