search

KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
71 stars 79 forks source link

Procedural SRBs cause heavy log spam when used with procedural fairings #293

Closed Tonas1997 closed 3 years ago

Tonas1997 commented 3 years ago

I don't know which mod is responsible for this issue, so I might post it in both repositories. However, and as my PC dies because of the log being spammed with this:

[LOG 00:06:47.738] [PF]: Calling FAR to update voxels...
[LOG 00:06:47.767] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): UpdateMaxThrust: minBurnTime = 2, maxThrust = 6000
[LOG 00:06:47.767] [ProceduralSRB] [ProceduralSRB.UpdateThrustDependentCalcs] UsingME? True, thrust 216.2, maxThrust 6000.0, burnTime 30.0, fuelRate 0.1, isp 220s Vac / 200s ASL
[LOG 00:06:47.767] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): bell scale: 0.3796117; thrust: 216.1576, thrust1m: 1500
[LOG 00:06:47.767] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): rescaling bell: 0.3796117
[LOG 00:06:47.767] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB) (595586392): MoveBellAndBottomNode: bottom node: (0.0, -1.7, 0.0)
[LOG 00:06:47.767] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): shifting: proceduralSRBRealFuels (Part) by (0.0, 0.0, 0.0)
[LOG 00:06:47.768] IR: [ServoController] OnEditorShipModified finished successfully
[LOG 00:06:47.769] [PF]: Calling FAR to update voxels...
[LOG 00:06:47.787] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): UpdateMaxThrust: minBurnTime = 2, maxThrust = 6000
[LOG 00:06:47.787] [ProceduralSRB] [ProceduralSRB.UpdateThrustDependentCalcs] UsingME? True, thrust 216.2, maxThrust 6000.0, burnTime 30.0, fuelRate 0.1, isp 220s Vac / 200s ASL
[LOG 00:06:47.787] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): bell scale: 0.3796117; thrust: 216.1576, thrust1m: 1500
[LOG 00:06:47.787] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): rescaling bell: 0.3796117
[LOG 00:06:47.787] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB) (595586392): MoveBellAndBottomNode: bottom node: (0.0, -1.7, 0.0)
[LOG 00:06:47.787] [ProceduralSRB] proceduralSRBRealFuels (ProceduralParts.ProceduralSRB): shifting: proceduralSRBRealFuels (Part) by (0.0, 0.0, 0.0)
[LOG 00:06:47.788] IR: [ServoController] OnEditorShipModified finished successfully
[LOG 00:06:47.790] [PF]: Calling FAR to update voxels...

it is probably an issue with the procedural SRB.

Here's the test configuration that causes this problem:

screenshot17

I should note that the FPS drop/log spam will happen regardless of the number of parts between the fairing bases (in the image I have that single yellow tank) or the root part.

The images below highlight the FPS impact:

screenshot18 screenshot19

Versions KSP - 1.10 ProceduralParts - 2.1.2.0 ProceduralFairings - 6.0.1.0

DRVeyl commented 3 years ago

Are you on the RO Discord? In the #testing-needed channel, there is a preview build of PF v6.1 and a preview build of ProcParts (the one by me on 10 JUL, not Stonesmile's demonstrator of new shapes immediately after). If you try those, is this issue resolved?

(Edit: I released PF v6.1, so if you could test with that, would be best.)

Tonas1997 commented 3 years ago

Yup, that seems to have fixed the issue 😄