search

KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
72 stars 79 forks source link

ProcSRB: RealFuels thrust value not updated when changing burn time #308

Closed lpgagnon closed 2 years ago

lpgagnon commented 2 years ago

New vessel, place command part (to get MJ dv), place ProcSRB part, open SRB PAW, open Engine GUI

Then change the value of the Burn Time slider.

MJ DV window shows the thrust changes, as does the PAW; but the Engine UI's thrust value isn't updated. (interestingly, the propellant flow value is updated)

Possible cause: ModularEnginesChangeThrust is never actually called https://github.com/KSP-RO/ProceduralParts/blob/952ed1ae3e17bb299777f9cf6a78f1937f62d5e3/Source/ProceduralSRB.cs#L440

Extra info: if I add an additional engine config (so there's something besides"Normal"), switching configs does update the thrust value, and the updated value does match the PAW thrust value

DRVeyl commented 2 years ago

Agree that's the cause. Fixing it breaks the sliding part of the slider. (Calling that method ends up completely reloading the configuration, which forces a PAW refresh, which breaks sliders.) Maybe I can throw it on a timer, though that's a little ugly.