KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
72 stars 79 forks source link

ProcSRB: Changing SRB Type has no effect #309

Closed lpgagnon closed 2 years ago

lpgagnon commented 2 years ago

New vessel, place command part, place procSRB, open SRB PAW, open Engine GUI

Bottom of the window shows Type: S, corresponding to the Surface type https://github.com/KSP-RO/ProceduralParts/blob/952ed1ae3e17bb299777f9cf6a78f1937f62d5e3/GameData/ProceduralParts/Parts/Tanks/4SRB.cfg#L336

Now change the SRB Type in the PAW, from Surface to Vacuum. Nothing seems to change; bell model stays the same, all the values in the PAW, MJ DV window and Engine GUI are unchanged; of particular interest, "Type: S" does not change to "Type: S+".

Unlike #308, ModularEnginesChangeEngineType does get called, so this may actually be a RF-side bug.

Manually changing the .cfg to make Vacuum the initial value does make the Engine GUI show "Type: S+", so the issue isn't that the S+ config can't be selected at all; it's the switch that isn't working.

On the other hand, if I switch the type then alt-click-clone the part, the clone does have the updated type (and bell model), so something somewhere knows about the switch.

Starcatcher2009 commented 2 years ago

New vessel, place command part, place procSRB, open SRB PAW, open Engine GUI

Bottom of the window shows Type: S, corresponding to the Surface type

https://github.com/KSP-RO/ProceduralParts/blob/952ed1ae3e17bb299777f9cf6a78f1937f62d5e3/GameData/ProceduralParts/Parts/Tanks/4SRB.cfg#L336

Now change the SRB Type in the PAW, from Surface to Vacuum. Nothing seems to change; bell model stays the same, all the values in the PAW, MJ DV window and Engine GUI are unchanged; of particular interest, "Type: S" does not change to "Type: S+".

Unlike #308, ModularEnginesChangeEngineType does get called, so this may actually be a RF-side bug.

Manually changing the .cfg to make Vacuum the initial value does make the Engine GUI show "Type: S+", so the issue isn't that the S+ config can't be selected at all; it's the switch that isn't working.

On the other hand, if I switch the type then alt-click-clone the part, the clone does have the updated type (and bell model), so something somewhere knows about the switch.

Save the vessel, clear the VAB and load it again.