KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
72 stars 79 forks source link

ProcSRB is hardwired to SolidFuel #313

Closed lpgagnon closed 2 years ago

lpgagnon commented 2 years ago

Haven't managed to get the whole puzzle straight in my head and leaving out a few steps, but the basic issue:

In ProcSRB, burn time and thrust are a function of each other (only one being user-controllable at a time) and of fuel mass

minimum burn time, and therefore max thrust, also depend on fuel mass

Fuel mass is derived from fuelResource.maxAmount

And the fuelResource is hardwired to be RESOURCE[SolidFuel]

In RealFuels-land, this works because the procSRB is given a MFT with a TANK_DEFINITION that just references a SolidFuel resource; resizing the procpart appears to keep RESOURCE maxAmount in sync, and the max thrust keeps increasing as part volume increases.

But it dooms any attempt at making ProceduralSRB use engine CONFIGs that consume real-world solid fuels. (╯°□°)╯︵ ┻━┻

Starcatcher2009 commented 2 years ago

Haven't managed to get the whole puzzle straight in my head and leaving out a few steps, but the basic issue:

In ProcSRB, burn time and thrust are a function of each other (only one being user-controllable at a time) and of fuel mass

minimum burn time, and therefore max thrust, also depend on fuel mass

Fuel mass is derived from fuelResource.maxAmount

And the fuelResource is hardwired to be RESOURCE[SolidFuel]

In RealFuels-land, this works because the procSRB is given a MFT with a TANK_DEFINITION that just references a SolidFuel resource; resizing the procpart appears to keep RESOURCE maxAmount in sync, and the max thrust keeps increasing as part volume increases.

But it dooms any attempt at making ProceduralSRB use engine CONFIGs that consume real-world solid fuels. (╯°□°)╯︵ ┻━┻

The problem is even the real solid fuels (assuming you're taking fuels from Realfuels) are the EXACT SAME thing. There's currently no way to figure out the difference between the fuels' density and overall energy-per-mass, so even if you modify the ProcSRB to use things like HTPB or PBAA...it will work the same as Solid Fuel.