search

KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
72 stars 79 forks source link

ProcSRB Fixes #314

Closed DRVeyl closed 2 years ago

DRVeyl commented 2 years ago

Fixes #301 Fixes #305 Fixes #309 Fixes #310 Fixes #311 Fixes #312 Fixes #313

TODO: Workaround for #308; notifying RF breaks the PAW: It causes it to reload the configuration, which refreshes the PAW, which with stock KSP invokes all symmetry event handlers even if there is no change. Either abandon the symmetry handler, track our own previous value, or apply a fix into CommunityFixes. It appears I'm one of the only authors that actually uses symmetry change handlers, most everyone else just implements their own into the primary change handler.

TODO: Disable the debug linerenderers by default before merging.

StonesmileGit commented 2 years ago

Minor issues remaining; Attached part to nozzle doesn't get pushed when nozzle size is changed (due to thrust changing). When changing the nozzle angle and the attached part is the parent, there are some issues with the offset, but it is minor.

With some notes somewhere that these issues are know, we could probably merge this since it's a great improvement over the current version.