KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
72 stars 79 forks source link

Newest update prevents loading of prior craft files #325

Closed JordanMilly closed 1 year ago

JordanMilly commented 1 year ago

Myself and others on the RO/RP-1 discord have run into the issue that the 2.4.2 release either prevents previous craft files from 2.4.1 from loading, or crashes the game. Only rolling back to 2.4.1 allowed the craft files to work again.

sebasma78 commented 1 year ago

Same here with a more stock configuration (no RO for me)

[LOG 19:27:53.026] [KSPCommunityFixes] Testing UpgradeScript ShapeBezierConeUpgrade from assembly ProceduralParts, using version 0.0.0.0 [ERR 19:27:53.026] [SaveUpgradePipeline]: Test Module ProceduralParts 2.1 Bezier Cone Upgrader KCT-GAME/SCENARIO/KSC/SPHPlans/KCTVessel/ShipNode/PART does not apply for Craft loading!

[ERR 19:27:53.026] [SaveUpgradePipeline]: Test Module ProceduralParts 2.1 Bezier Cone Upgrader KCT-GAME/SCENARIO/KSC/VABPlans/KCTVessel/ShipNode/PART does not apply for Craft loading!

[ERR 19:27:53.026] [SaveUpgradePipeline]: Test Module ProceduralParts 2.1 Bezier Cone Upgrader KCT-GAME/SCENARIO/KSC/SPHWarehouse/KCTVessel/ShipNode/PART does not apply for Craft loading!

[ERR 19:27:53.027] [SaveUpgradePipeline]: Test Module ProceduralParts 2.1 Bezier Cone Upgrader KCT-GAME/SCENARIO/KSC/VABWarehouse/KCTVessel/ShipNode/PART does not apply for Craft loading!

[ERR 19:27:53.027] [SaveUpgradePipeline]: Test Module ProceduralParts 2.1 Bezier Cone Upgrader KCT-GAME/SCENARIO/KSC/SPHList/KCTVessel/ShipNode/PART does not apply for Craft loading!

[ERR 19:27:53.027] [SaveUpgradePipeline]: Test Module ProceduralParts 2.1 Bezier Cone Upgrader KCT-GAME/SCENARIO/KSC/VABList/KCTVessel/ShipNode/PART does not apply for Craft loading!

[LOG 19:27:53.027] [KSPCommunityFixes] Testing UpgradeScript ShapeBezierConeUpgrade from assembly ProceduralParts, using version 0.0.0.0

NathanKell commented 1 year ago

Sorry I forgot to respond to this when I fixed it. It was a stock bug that PP 2.4.1 exposed (KSP's SaveUpgradePipeline breaks if you define an UpgradeScript that applies in only one, rather than both sfs/craft, contexts). I fixed that stock bug in KSPCF 1.22.2.