KSP-RO / ProceduralParts

A continuation of StretchySRBs, which is a continuation of StretchyTanks
72 stars 79 forks source link

USI-LS tanks begin with NaN resources, causing bugs #356

Closed arbsoup closed 2 months ago

arbsoup commented 2 months ago

When a USI-LS life support tank is dragged from the part list into the build area, right-clicking shows no supplies are loaded and that the tank has no mass. Changing tank type will show resources starting out as NaN; while these can be changed manually, it interacts very weirdly with the existing symmetry issue as shown here, causing errors in the log and problems like KER miscalculating tank mass, tanks being empty on launch, and so forth.

The fix was super easy: I just changed !MODULE[ProceduralPart] {} MODULE to @MODULE[ProceduralPart] in the USI-LS compatibility file under ZOtherMods. I wasn't sure about submitting a PR because I'm kind of a noob with ModuleManager and I don't know if there were better ways to do it. Thanks for your understanding.