Mount rotation gets forgotten

[lpgagnon]

Build rocket, give it a rotatable mount, rotate the mount, all seems fine. Start a sim: mount is back to non-rotated state. Revert to vab: mount is still unrotated, and the rotation sliders have disappeared. Selecting a different mount then back to original brings the sliders back.

Same with saving & loading .craft files; after load, rotation is reset and sliders are missing, sliders come back after changing nose/core/mount selection

I'm guessing the "real bug" is the missing sliders, and the rotation reset is a consequence of that

ROLib 1.3.1, ROTanks 2.5

(originally mentioned on discord to see if anyone would confirm, but nobody bit)

[Falki-git]

Can confirm.

ROLib 1.3.1, ROTanks 2.5

Before SIM:

After SIM:

[al2me6]

Fixed by https://github.com/KSP-RO/ROLibrary/commit/4fbcd31259cd7ce9bfdf98a30773651ae7ddcbd2.

FWIW, there were three four bugs:

• Rotations got reset on load
• Mounts' intrinsic rotation offsets were not dealt with coherently
• Rotation sliders did not show up on load
• Rotations were getting double-applied when switching variants while there is a nonzero rotation applied