KSP-RO / RP-1

Realistic Progression One - Career mode for Realism Overhaul
Other
335 stars 213 forks source link

Science reports #156

Closed NathanKell closed 5 years ago

NathanKell commented 9 years ago

Here are the first pass of experiments that should have reports added. Note that for obvious reasons the HSF stuff is low priority for anywhere except space and the Moon (and Mars).

Note that no surface/splashed text needs to be made for Earth, since that's disabled.

Instruments:

Probes

Human Spaceflight (HSF):

Warp11 commented 9 years ago

Whats the geiger counter in the google form?

NathanKell commented 9 years ago

The geiger counter. :) It's at the bottom.

Warp11 commented 9 years ago

It's not there... For me the last one is the bio drill scan. Is it the x-ray diffraction scan?

Shurichan commented 9 years ago

The probe core report added by RP-0 does not appear to be listed.

NathanKell commented 9 years ago

@Warp11 that's weird. @Felger I can't remember, did you give me access to the backend as well?

NathanKell commented 9 years ago

I didn't even have it listed here, you're quite right. Sorry it only took me four days to realize what you were talking about. :\

Warp11 commented 9 years ago

All good :D

Warp11 commented 9 years ago

Posted this on the forum thread, just gonna put it here as well:

Would you like us to put in the same text for multiple biomes if it fits or is someone going to go through it and do that? It just takes a long time for us to do that in the google form because you can't just select multiple biomes. And also, I think it is sensible to write pluto reports based on the New Horizons data, assuming that they will make sense when the textures are updated.

EDIT: just saw that that you can select no biome. Would that be good as indication that it is meant for all? And it should be possible to use some of the Stock/Crowd Sourced science reports, especially for Earth. Would you like me to have a look through these and make you a list?

Warp11 commented 9 years ago

And I suppose the orbital telescope would be an observation from the distance, like with hubble? Do we still have some sort of seismic scan, because that is quite a reasonable and interesting experiment for many bodies. Thx

NathanKell commented 9 years ago

Yes. Although I highly recommend only doing reports for the experiments listed on this issue--they're by far the highest priority. I'll either make a clone or use something from DMagic for that (seismic). I agree it's a very reasonable/interesting/real thing, it's just out of scope for the early tree except for soft-landers.

Warp11 commented 9 years ago

I'll go through it and make you an Excel list. Is there a specific format you would like it in? E.g. like what the google form is putting out? If so maybe just share the google doc with me so I can put it in there. Do you want me to include the ones that are more funny than scientific?

NathanKell commented 9 years ago

Sure! PM me your email and I'll share the doc.

jhathawaytn commented 9 years ago

Hi Nathan. Just wanted to say thank you for this fantastic community which I've been following for a very long time. But I can't sit on the sidelines any longer. This objective seems doable for me. So with that said, is there a way to see what's already been submitted through the google form? Just wondering, because I'd rather work on a planet/experiment that's lacking material. Thanks.

NathanKell commented 9 years ago

Sheet link: https://docs.google.com/spreadsheets/d/1WeuKC0aJGLwB4iJv85BmBbaVBASX56tYLaRNcKTx3z0/edit?usp=sharing

NathanKell commented 9 years ago

And @jhathawaytn thanks so much! :)

NathanKell commented 9 years ago

@Felger the link in the RO channel goes to a form that apparently outputs to the 'deprecated' page of the sheet. Should that not be the link used?

jhathawaytn commented 9 years ago

@NathanKell I put two reports in on Saturn, but I'm not seeing them show up in the above sheet link. I just want to make sure these are getting captured before I drop several in.

Warp11 commented 9 years ago

@jhathawaytn I can't see them in the sheet. Did you finish the whole survey? The results only get counted if you click through all the planets after the one you started with (you don't have to write anything there)

jhathawaytn commented 9 years ago

@Warp11 Well Duh! I should have known that. Thanks for clarifying.

DMagic1 commented 9 years ago

I'm not sure how you're dealing with science reports (using MM to replace, or add to existing reports?), but I already have pretty extensive RP-0 reports included in my own ScienceDefs.cfg file. For a more readable version you can check the Excel file for existing reports.

There is lots of room for biome specific results, and some of the experiments only have one or two results, but most planets are pretty well covered; Earth has none.

If you are replacing existing reports you can copy the results from my files. Or they should just work as is if my ScienceDefs file isn't being altered.

Warp11 commented 9 years ago

@DMagic1 That is awesome and will surely help. We still need reports for experiments that are not from you mod though. We encountered an issue where only the first report I put in gets displayed and no others. Any ideas on that? code: https://raw.githubusercontent.com/KSP-RO/RP-0/e2e7f284723191af4b78d7886db23e64fb9d1361/GameData/RP-0/Science/Results/SurfaceSample.cfg Thx

NathanKell commented 9 years ago

@DMagic1 that's awesome! I'll be sure to change the cfg to not nuke them then. :)

Warp11 commented 9 years ago

now that #154 is closed it seems like the release is a lot closer. And honestly I don't really have the time at the moment to do all the report cfgs on my own. It would be great if some other other people could join in there. Sry for that, this is just a busy time for me.

jhathawaytn commented 9 years ago

@Warp11 Hey Brother...I can help out where possible...Not a scripting guy at all, but if we're just talking Cfg files then I'm probably good for that. If you could just get me started I can certainly fill in the blanks. I looked over the SurfaceSample.cfg and it looks pretty straight forward.

Warp11 commented 9 years ago

Thx so much, that is awesome. it is pretty straightforward. Have a look at this: https://github.com/KSP-RO/RP-0/commit/e2e7f284723191af4b78d7886db23e64fb9d1361 for the formatting. Best thing might be to copy that file. Then replace surfaceSample (top line) with whatever experiment you're doing. You can find the experiment names here: https://github.com/KSP-RO/RP-0/tree/master/GameData/RP-0/Science/Experiments and the biome names in RSSKopernicus.cfg. One more example (not finished yet): http://pastebin.com/1gT7ddgr Logs: https://docs.google.com/spreadsheets/d/1WeuKC0aJGLwB4iJv85BmBbaVBASX56tYLaRNcKTx3z0/edit?pli=1#gid=278947428 maybe start with instruments. Thx

jhathawaytn commented 9 years ago

@NathanKell I see some situations are listed multiple times. I assume they will be picked random? If this is the case, is it ok to also pull from DMagic1's excel file?

jhathawaytn commented 9 years ago

@NathanKell And thanks for the directions. I'll probably start with Temp.

Warp11 commented 9 years ago

@jhathawaytn They are suppsed to be picked at random. However that's not working. It's only displaying the first one. We're not sure how to fix that yet.

NathanKell commented 9 years ago

@jhathawaytn great! :) Note that the experiment names are inside those files that @Warp11 linked, not just the name of the file. Open one of them and look for @EXPERIMENT_DEFINITION:HAS[#id[namehere]] That's the name.

jhathawaytn commented 9 years ago

Guys, Ok..I need a bit of insight. The "Temperature Scan" instrument is meant for a more local reading, i.e. digital thermometer? Then the Multi Spectral Analysis instruments could also be used for more of a remote temp scan? Or is the Temperature Scan meant to capture both local and remote? I'm asking this because as I build this config file, I'm adding as much as I can since there isn't much in the excel file for temps and it kinda makes a difference in some of the situations.

Also, I'm making these comments more scientific, based on hard facts rather than silly commentary. Temp Scans are just that...data. Hope that is ok!?

Examples: MercuryFlyingLowSouthPole = Day and Night cycles have little impact on temperatures; they average a constant 180 K (-93 C).

VenusFlyingLow = Our sensors are experiencing extreme heating cycles, with temperatures rising by over 100ºC during several 100 second-long passages through the atmosphere.

MercurySrfLandedMajorCraters = The crater's rim cast a shadow on the landing site. Here the temperature measures 108.8 K (-164.4 C).

DMagic1 commented 9 years ago

@Warp11 Is it possible that MM has some issues with trying to add multiple values with the same name?

You can try verifying the number of possible results for each experiment (I think) with ScienceExperiment.Results.

@jhathawaytn The Multi Spectral Analysis experiment has a far IR spectrometer that does basically that, measures temperature. It can also be used for other things, like determining surface or atmospheric composition, and surface mapping.

jhathawaytn commented 9 years ago

@DMagic1 Thanks! So based on your comments I'll keep the Temp Scans local. In other words, there is no way to get a surface reading using temp scan instrument from say flyinghigh above for example. That would require Multi Spectral instrument.

Warp11 commented 9 years ago

@DMagic1 I've got no idea how MM works and no real experience in modding, I'm really just putting the reports from the excel into cfgs.

NathanKell commented 9 years ago

@jhathawaytn that's perfect, RP-0's tone is very much that rather than "Oops you died haha." I suggest you add results to start with only for the experiments in the folder @Warp11 linked, i.e. what's listed at the top of this thread; @DMagic1 already has results for those instruments well in hand.

@DMagic1 the file adding experiments so far is here and it looks fine to me. ConfigCache shows it being patched properly, too. I'll add a bit of code to check that as you say, though The issue however isn't that only one result is registering, but that it always picks the first entered result for each situation/biome.

jhathawaytn commented 9 years ago

@NathanKell Thanks Nathan! I'm currently working on Temp and Film Return. Is it safe to assume for Film Return, that I'm only writing results for Earth and Moon for now?

And should I upload these two files as I work on them? I'm not familiar with that process.

NathanKell commented 9 years ago

@jhathawaytn Awesome! For film return, yeah, that seems safe enough. If you can, perhaps some non-biome results for Mars/Venus/Phobos/Deimos, as those are just barely possible enough, but certainly don't worry about further afield than that.

I'd suggest forking this repo, then editing your files in the fork (and committing and syncing frequently to avoid losing work for any reason, and in case you want someone to check over a syntax question). Then when you're done you can just create a pull request and it'll flow into this. :)

Warp11 commented 9 years ago

I've got the crew report and surface sample almost done, at least what we got in the excel sheet.

Also the survey only has titan and no other moons of saturn.

NathanKell commented 9 years ago

@Warp11 Yeah, the survey needs updating. For now, concentrate on Earth, Moon, and only then Mars/Venus/Phobos/Deimos, and only then the other bodies. Can you commit what you have within the next 30 minutes or so? I'd like to release an official build of RP-0 tonight, before I go to a place with poorer net access....

Warp11 commented 9 years ago

I'm on it

Warp11 commented 9 years ago

I can't do Saturn biome based stuff though until the biomes there are fixed. But no one is gonna need crew reports there any time soon anyway.

NathanKell commented 9 years ago

@Warp11 awesome, thanks! As to Saturn, it is fixed. Grab RSS from git. :)

Warp11 commented 9 years ago

Is the new version on CKAN?

NathanKell commented 9 years ago

No, I mean replace your RealSolarSystem folder with the one in GameData when you download the KSP-RO/RealSolarSystem repo as a zip. I plan to release tonight tho.

jhathawaytn commented 9 years ago

@NathanKell Hey man, I'm finished with the film return cfg file. At least for now; as discussed I only covered Earth, Moon, Venus, Mars and it's moons. Of course there could be much more data added, but for now, I'm heading back over to Temps and then Pressure. I did a pull request; hope I did it right.

jhathawaytn commented 9 years ago

Another Newbie question..sorry.....So after I pull a file, and I then want to update it, how do I do this? Do I update the file in my folk and then pull it again?