Tracking Issues with new contracts

[stratochief66]

I'm creating this Issue to track any feedback people have with the new contracts for 1.2 that @pap1723 was nice enough to create for us.

Whether it is a spelling or grammar mistake, a description and goal that don't match (like, text says you must get to 140km but it triggers at 100km), a contract that appears broken or has a bad trigger, etc, please mention it here. Please describe the issue you have in as much detail as possible, and ideally link to the Contract you're discussing, or call it by its One True Name. https://github.com/KSP-RO/RP-0/tree/master/GameData/RP-0/Contracts

@pap1723 feel free to edit this Issue to your liking, or direct people who mentions issues here.

[Sander815]

I would like to help with testing this, but are these contracts already in the master branch? Because the latest change in that link seems to date from 2 months ago.

[pap1723]

The contracts are in the Pap-Contracts branch, which as of yesterday, is up to date with the master branch for all other commits than the contracts.

So in other words, use the Pap-Contracts branch and thanks for testing!

On Fri, Jun 2, 2017 at 11:10 AM, Sander815 notifications@github.com wrote:

I would like to help with testing this, but are these contracts already in the master branch? Because the latest change in that link seems to date from 2 months ago.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KSP-RO/RP-0/issues/670#issuecomment-305834199, or mute the thread https://github.com/notifications/unsubscribe-auth/ASjbfyo8FvCIY3hT5GfYeRX5pvahzuyJks5sADPdgaJpZM4NtSXy .

[Sander815]

In the first_Orbitrecover contract the "reach 6500m/s" is checked on launch. The contract completes with a tiny hop on the launch pad.

[glilienthal]

In general the new contracts seem to generate a lot less money than the old ones. Is that on purpose? Is that a good balance? Considering that the F-1 research costs almost as much as the whole moon landing brings. (Or did that change? )

[glilienthal]

I love that we have now a mars landing contract, and sample returns, and, and, and! I'll test this the next time rl doesn't interfere with KSP.

[pap1723]

@glilienthal for things like the Moon Landings, I used almost the exact same values as before. What you have to remember is the values inside the contract CFG files are not necessarily what you receive upon completion.

I have classed many more missions than previously as Exceptional prestige. These pay 1.5x the listed value in the CFG. Also, missions to the Moon pay 3.5x the listed values in the CFG. So, if a CFG file shows the payout for an Exceptional mission to the Moon to be 100,000, it is actually 100,000 x 1.5 x 2.5 = 525,000.

Edit: Fix wording to make more sense

[pap1723]

@Sander815 where did you launch from?

[pap1723]

@NathanKell I hardly modified that first_OrbitRecover contract. Do you know why it is setup to just require orbital velocity to be reached instead of a true orbit?

[NathanKell]

@pap1723 because you might be going 7.5km/sec with a 140km apogee (i.e. never even go suborbital, by KSP terms, since 140km is the atmo interface) and that should be fine. In general, any suborbital (in real, not KSP terms) flight over 6.5km/sec should broadly man-rate the heat shield (c.f. Big Joe).

[pap1723]

That makes sense. I will change the contract to require traveling at least 6500 km on at least a suborbital trajectory. Should fix the error that was reported.

On Jun 5, 2017 5:36 PM, "NathanKell" notifications@github.com wrote:

@pap1723 https://github.com/pap1723 because you might be going 7.5km/sec with a 140km apogee (i.e. never even go suborbital, by KSP terms, since 140km is the atmo interface) and that should be fine. In general, any suborbital (in real, not KSP terms) flight over 6.5km/sec should broadly man-rate the heat shield (c.f. Big Joe).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KSP-RO/RP-0/issues/670#issuecomment-306330013, or mute the thread https://github.com/notifications/unsubscribe-auth/ASjbfySROpHmSKRO7dnv_h17wj8AS0ZTks5sBIL9gaJpZM4NtSXy .

[NathanKell]

Here is Big Joe for reference. Trajectory: 153km apogee, 2292km downrange, 6657m/s max velocity (I presume ECI not ECEF, so rather lower ECEF). See Also.

[Sander815]

Another strange bug: I just did the first_MoonFlybyUncrewed contract and the contract completed at 5000km above the moon, without sending any science. Can someone maybe try to replicate this? Because combined with the previous bug I'm starting to think there might be a problem on my end.

@pap1723 All my current launches are from Baikonur.

[NathanKell]

Was not able to confirm last night. Contact did not complete without science.

On Jun 6, 2017 10:05 AM, "Sander815" notifications@github.com wrote:

Another strange bug: I just did the first_MoonFlybyUncrewed contract and the contract completed at 5000km above the moon, without sending any science. Can someone maybe try to replicate this? Because combined with the previous bug I'm starting to think there might be a problem on my end.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KSP-RO/RP-0/issues/670#issuecomment-306552555, or mute the thread https://github.com/notifications/unsubscribe-auth/AE5-IkMSYJBNkOL1soDRVXlah2CegwUDks5sBYbxgaJpZM4NtSXy .

[leudaimon]

The same as Nathankell. Completed the contract twice, both times needed to transmit science before completion. Relevant info (and intended in the contract), you can complete it even if you transmit science from the Moon's SOI before reaching 5000km.

[Sander815]

Yes, I just noticed that too, I was a bit too hasty. The contract works fine, I just send the science first, then reached 5000km, and the contract completed. I just thought It was meant you had to transmit science from below 5000km.

Did anyone else try doing a small hop on the first_Orbitrecover contract?

[glilienthal]

RE: amount of payouts: Yes, makes total sense. The amounts are the same. I believe you, and I looked at them.

[rsparkyc]

For the sun-synchronous satellite, we don't actually enforce that we're in a synchronous orbit. Wikipedia has a good table for orbital period, altitude, and number of orbits per day: https://en.wikipedia.org/wiki/Sun-synchronous_orbit Should we implement some or logic in the contract to align with one of the items in that table?

[NathanKell]

For first solar powered satellite, is it as intended that a new vessel is not required?

On Jun 7, 2017 9:10 AM, "Ryan Caskey" notifications@github.com wrote:

For the sun-synchronous satellite, we don't actually enforce that we're in a synchronous orbit. Wikipedia has a good table for orbital period, altitude, and number of orbits per day: https://en.wikipedia.org/wiki/ Sun-synchronous_orbit Should we implement some or logic in the contract to align with one of the items in that table?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KSP-RO/RP-0/issues/670#issuecomment-306844423, or mute the thread https://github.com/notifications/unsubscribe-auth/AE5-Io1lWyu98WVg4QY8aeI4rWwMJfhkks5sBsuDgaJpZM4NtSXy .

[pap1723]

Thanks for the updates! I have fixed the Solar Powered Contract to require a NewVessel and I have modified the Lunar Orbiter contract slightly to not fire early.

[NathanKell]

Orbit Recovery contract: the orbit/speed states lack disableOnStateChange = true which means that as soon as you leave the state they uncomplete, or at least they did for me just now (last ~10 minutes of the Soviet stream on twitch I just did). I suggest trying with disableOnStateChange = true like the First Crewed Orbit contract.

This may not be your bug, of course, it might date back to me. :)

[pap1723]

You are using the older version of that contract (I uploaded a new one yesterday), but even in the new one, I forgot to have the disableOnStateChange = true value set. Fixed now!

Also made the margin of error smaller in the initial First GEO contract.

[NathanKell]

Ah, gotcha! And sorry, thought I'd done a pull.