search

KSP-RO / RealAntennas

KSP Mod to add better antenna / link calculations to CommNet.
2 stars 5 forks source link

Planner reported antenna bitrate does not match actual antenna bitrate at high modulation values #21

Closed Capkirk123 closed 3 months ago

Capkirk123 commented 3 months ago

For modulation values greater than QPSK (2 bits), the planner reported max antenna bitrate is incorrect (although the calculated link speed is correct).

When moving from BPSK to QPSK encoding, antenna reported max bitrate doubles (as expected). However, when moving from QPSK to 8PSK, antenna reported max bitrate only increases by a factor of 1.5 (while actual performance doubles, as expected). This continues with 8PSK -> 16PSK only reporting a 1.33x increase, 16PSK -> 32QAM only reporting a 1.25x increase, and 32QAM -> 64QAM only reporting a 1.2x increase.

Although this doesn't actually have any gameplay effect (connections are still correctly calculated as if bitrate doubled for each modulation step), it results in the planner reporting absurd and confusing connections where the achieved link is several times faster than the reported maximum antenna speed.

Capkirk123 commented 3 months ago

https://github.com/KSP-RO/RealAntennas/issues/20 and https://github.com/mockingbirdnest/Skopos/issues/10 are both symptoms caused by this issue, incorrectly diagnosed by yours truly