search

KSP-RO / RealFuels

Modular fuel tanks and engines, with real fuels and realistic performance.
54 stars 66 forks source link

Update Aniline22 and Aniline37 fuel #304

Closed Peter-JY closed 1 year ago

Peter-JY commented 1 year ago

In ROEngines and Taerobee, the engine Aerobee need Aniline22 as fuel. But in RealFuel, there isn't a fuel called Aniline22 as well as Aniline37, which is used in RO (You can see it here). So I update these two fuels to RF, and create this pull request.

After several tests, now I can use Aerobee engine in KSP 1.12.1 with the fuel Aniline22.

Capkirk123 commented 1 year ago

RO creates Aniline22 and Aniline37 here.

Peter-JY commented 1 year ago

Although RO tried to create Aniline22 and Aniline37, but it failed. So I createed this request : (

Peter-JY commented 1 year ago

in KSP 1.12.4, RO 14.21.0, RF 15.3.1

Peter-JY commented 1 year ago

or it's a bug for RO or RF

Capkirk123 commented 1 year ago

It has been like this for over a year and nobody has had any issues so far. What kind of tank are you trying to use? Really old stuff might not be configured

Peter-JY commented 1 year ago

I've tried A-4 Nose Section Aerobee FT-LF3 Propellant Tank and others from Taerobee, Atlas SLV-3C/D Fuel Tank and others from FASA, C7 Brand Adapter - 2.5m to 1.25m from Stock (RO Config), R7 Soyu-U2 Block A and others from RN Soviet Rocket, Saturn S-I/IB Propellant Tank from Real Scale Boosters (these are only a part of mods I installed) (by the way, these mods are designed for RO or RP-1, which had been in the list of recommend/suggest mods of RO or RP-1), but they all can't fill the fuel Aniline22.

Tested under latest RP-1 and KSP 1.12.4. All the names of tanks and its origin mod are what it shown in RP-1.

Capkirk123 commented 1 year ago

Those are all very old mods that haven't been updated in a long time, so that's not unexpected. Procedural tanks can hold aniline22/37. I'll look into trying to support those mods as well.

Peter-JY commented 1 year ago

So is it possible to merge this change of RF? By the way, I've found that ROTanks can hold Aniline22/37, maybe because this change is only effective on ROTanks and Procedural Tanks.

zer0Kerbal commented 1 year ago

Those are all very old mods that haven't been updated in a long time, so that's not unexpected. Procedural tanks can hold aniline22/37. I'll look into trying to support those mods as well.

yes old, but now maintained and being updated.

zer0Kerbal commented 1 year ago

upon review - the issue lies here: https://github.com/KSP-RO/RealismOverhaul/tree/master/GameData/RealismOverhaul/RO_SuggestedMods/Taerobee

marsh1832 commented 1 year ago

The real question is what in taerobee do you even want or need? It seems to me the majority of people who think they need taerobee have not yet realized you can change the size of the inline parachute. You can make all these parts procedurally with the added benefit of always being up to date without a patch

Capkirk123 commented 1 year ago

Ok, let me step in here. The issue does not, in fact, lie with the taerobee configs. Rather, as @Peter-JY has identified, the old tank types where never given the Aniline22/37 resource, only newer tank types. This means older parts which use those tank types can't use aniline22/37.

The question now lies with @NathanKell as to whether aniline22/37 should be added to these tank types in RO (since this fuel type was created as a workaround for RO), or whether we should just move everything to RF.

zer0Kerbal commented 1 year ago

the issue is also with the Taerobee configs - since they use the wrong part names.

Peter-JY commented 1 year ago

In old KSP versions (e.g. 1.3.1, in which RP-1 is firstly released), there's only Aniline, no Aniline22 or Aniline37 (If you wanted, you an see it in https://www.bilibili.com/video/av24301845, 12:29 in the stage panel). So the issue is whether we should add these 2 new type of fuel into RealFuels.

Peter-JY commented 1 year ago

And, due to I didn't find any introduction to Aniline22 or Aniline37, what does these numbers mean? The molarity? Or volume fraction?

Peter-JY commented 1 year ago

As far as I know, Aerobee uses nitric acid and aniline (maybe HNO3 with C6H7N), but in game it's 1.28% aniline22, 1.85% IFRNA(mainly HNO3), and mostly 96.87% nitrogen(N2). so where does this statistic come from? is it true? (because of too much N2)

Capkirk123 commented 1 year ago

This should resolve the issue. The fuel types are created in RO, so the tanks should be patched in RO as well.

siimav commented 1 year ago

Added in https://github.com/KSP-RO/RealismOverhaul/pull/2775