search

KSP-RO / RealFuels

Modular fuel tanks and engines, with real fuels and realistic performance.
54 stars 66 forks source link

Expose propellantStability directly without rounding #331

Closed lamont-granquist closed 10 months ago

lamont-granquist commented 11 months ago

Introduces GetPropellantProbability/GetUllageProbability to get the rounded version that forces veryStable to 100% (couldn't think of a better name, even though this isn't really the proper probability since the exponent isn't applied).

This lets MJ 'see' values between 0.996 and 1.0

Didn't get this compiling yet because of all the RF deps and ROUtils in particular so be a little careful before merging.

NathanKell commented 11 months ago

While we're waiting on the CKAN folks to merge the PR to put ROUtils on netkan, it does exist on github if you want to grab it (KSP-RO/ROUtils). But the code certainly looks like it'd build. :D

And per the review I'd just push the Pow down into the function so it's not a lie.

NathanKell commented 11 months ago

(Thanks for doing the debugging and PR work btw! 👍 )

lamont-granquist commented 11 months ago

Okay I made GetPropellantProbability() really be the probability. This change now actually updates the PAW to be the probability rather than stability--but that feels like the right thing to expose to the ultimate end user?

Also downloaded ROUtils release and validated it compiles, but now haven't tested anything.