search

KSP-RO / RealSolarSystem

Changes KSP's solar system to make it like the real one.
128 stars 92 forks source link

Phobos SOI too small #287

Closed Losalex42 closed 1 year ago

Losalex42 commented 1 year ago

SOI is the same as the radius. Makes it impossible to orbit or land on.

20.0.0 KSP 1.12.3

siimav commented 1 year ago

That certainly isn't the case on my install. image

Losalex42 commented 1 year ago

Kerbal Space Program Screenshot 2023 06 21 - 15 06 21 67 Very strange.

siimav commented 1 year ago

I'm going to bet that this is a conflict with some other mod and not actually an issue with RSS itself.

Losalex42 commented 1 year ago

I've whiped my ksp folder and reinstalled everything and using the bare minimum to get rss working. It's still an issue. I did use CKAN though.

Losalex42 commented 1 year ago

I downgraded to rss v19.1.0 from 20.0.0 and that fixed the issue.

siimav commented 1 year ago

Ahh, so turns out that the install I had open at that time was running RSS v19.1. Can confirm that the issue started happening in v20 so it has to be related to #285.

Not sure why setting finalizeOrbit to false caused other side effects rather than just the orbital period changes. Maybe @R-T-B has ideas?

gotmachine commented 1 year ago

From one of my comments on the issue :

I'm not entirely sure why the FinalizeOrbit() method is also recomputing the hill sphere and SOI, this seems like something that should be independent of the period / meanMotion hack, so in case setting finalizeOrbit = true also has this purpose, I would suggest gating the hack behind an additional config switch so planets configs can opt-out of it.