KSP-RO / RealismOverhaul

Multipatch to KSP to give things realistic stats and sizes
374 stars 279 forks source link

RD-107/108 vernors, main engine are separate modules, configs applied inconsistently #2048

Closed fat-lobyte closed 2 years ago

fat-lobyte commented 5 years ago

The RealEnginesPack version for the RD-107/108 engines and its derivatives features two different engines: The main engine and the small vernor engines. While this may seem like a good idea at first, there are two main problems with it:

Is there a way to simply drop the separate config for the vernors, add vectoring to the main engines and make only the model act like the vernor engines are moving?

PhineasFreak commented 5 years ago

Yep, that is something that currently affects every engine that has auxiliary engine modules (like the LR91 turbopumps or the RD-107/108 verniers). There is a plan to migrate everything to use THRUST_TRANSFORM multipliers but not everything implements that fix (IIRC the SXT X-405 engine does).

Attached are the semi-reworked RealEngines patches. They will not work as-is for RO but it is a starting point for any interested party in order to implement the required fixes for RO itself.

RE_RealEngines_Russian.zip

Edit: and a more "direct" config, part of the DECQ Soyuz LV: https://github.com/KSP-RO/RealismOverhaul/blob/master/GameData/RealismOverhaul/RO_SuggestedMods/DECQ/RO_DECQ_R7.cfg#L1449-L1473

DRVeyl commented 2 years ago

My understanding is this is fixed for RealEngines. I defer to @Capkirk123 on engine configs, but believe this has been resolved generally in the past few years. Will leave open briefly if anyone has conflicting information.