search

KSP-RO / RealismOverhaul

Multipatch to KSP to give things realistic stats and sizes
369 stars 280 forks source link

RealFuel not working with tanks from making history dlc. #2918

Closed aishwarya25252 closed 11 months ago

aishwarya25252 commented 11 months ago

Tanks like FL-TX1800 FL-TX900 has no tank options when using RO , it has all options when using Real Fuel with stock like config without RO . MK2 pod from the same DLC has RealFuel tank options. Is it a bug or expected ? Because these tanks don't show as WIP or non RO .

NathanKell commented 11 months ago

We probably should make all the DLC parts WIP, but then again there's a ton of older parts that have questionable configs too.

aishwarya25252 commented 11 months ago

Could you point me to the documentation for this codebase I'll try and fix this bug myself If that's alright you can assign me to this issu ?

NathanKell commented 11 months ago

Thanks! The pins (and the people) in #moddev-help in the RO discord are probably the best reference. There's also some articles on the wiki under the Contributing section.

aishwarya25252 commented 11 months ago

I have found the place and added the configs seems real fuel doesn't have configs for volume of the fuel tanks found in this DLC , RO has the required configs to support these tanks so they so up without any option for fuels . I have added the config with calculated volume and have tested it works now . Made a pr in the real fuels repo . https://github.com/KSP-RO/RealFuels/pull/330 , merging it would solve this issue .

aishwarya25252 commented 11 months ago

@NathanKell thanks for the support .

NathanKell commented 11 months ago

Thanks for making the PR! :)