KSP-RO / SolverEngines

A subclass of ModuleEnginesFX which supports AJE-style solvers.
8 stars 19 forks source link

SolverEngines toolbar GUI #9

Closed A1Ch1 closed 9 years ago

A1Ch1 commented 9 years ago

When not using the blizzy bar, the SE GUI appears in the stock toolbar. If the blizzy toolbar is installed, the SE GUI disappears from the stock toolbar as intended, but doesn't appear as an option for the blizzy bar.

NathanKell commented 9 years ago

I thought this was fixed in the current release...You're on the current release, right? Tagging @blowfishpro

blowfishpro commented 9 years ago

There was a NRE preventing it from showing up in the Blizzy toolbar. I implemented a fix a couple of days ago which seemed to work when I tested it.

NathanKell commented 9 years ago

Yeah, checking the current code in git I saw no bad characters--and that code was released in 1.8. So that's why I'm confused.

A1Ch1 commented 9 years ago

Hmm, yeah, using SolverEngines 1.8 and Toolbar 1.7.9. I'll check again, maybe I just missed it...

A1Ch1 commented 9 years ago

You're right, it's right there at the top of the list. Don't know how I could have overlooked it. My bad :)

NathanKell commented 9 years ago

No probs, glad it's sorted. :)

A1Ch1 commented 9 years ago

Scratch that, the SolverEngines GUI disappears after liftoff...

blowfishpro commented 9 years ago

Can't replicate. Could you provide more information?

A1Ch1 commented 9 years ago

Yes, testing

A1Ch1 commented 9 years ago

https://youtu.be/ppm8AXtIh1M?t=55s

SolverEngines button disappears from toolbar at 43 seconds after launch (1:05 in video), although the open SolverEngines GUI itself remains. SolverEngines also disappears from Configure Visible Buttons

Output log: https://www.dropbox.com/s/dyuz3fj2h37nwu6/output_log.txt?dl=0

blowfishpro commented 9 years ago

Okay, I figured out why this is. It happens when another vessel (e.g. a lower stage) goes out of physics range, and its VesselModule components are destroyed. I'll work on fixing this.

This is a reminder why you should never blindly copy someone else's code without question, even someone you trust to write good code (ferram4). It appears that this happens in FAR too.

A1Ch1 commented 9 years ago

:+1: Thank you!

blowfishpro commented 9 years ago

Should be fixed now