search

KSP-RO / TacLifeSupport

Life Support from Thunder Aerospace Corporation
Other
43 stars 24 forks source link

Missing kerbalEVAVintage and kerbalEVAfemaleVintage #117

Closed linuxgurugamer closed 5 years ago

linuxgurugamer commented 5 years ago

The expansion added these two new kerbal parts, you don't have them in the code as of now, at this location:

https://github.com/KSP-RO/TacLifeSupport/blob/49eba6ba1e7d4498a7ff0550d28b8014b1a4fdd9/Source/AddLifeSupport.cs#L57

I also didn't see the kerbalEVAfemale there

JPLRepo commented 5 years ago

because that's not how it works. There was an issue regarding MH kerbals if you didn't have MH installed which has already been fixed.

7ranceaddic7 commented 5 years ago

how does it work? Maybe you could provide some insight into this problem.

JPLRepo commented 5 years ago

Yeah they should try using null checks.

linuxgurugamer commented 5 years ago

What was the issue about missing MH kerbals, apparently one of my mods is running up against that as well. Thanks

linuxgurugamer commented 5 years ago

And I see that I misread the line, sorry for the false alarm

JPLRepo commented 5 years ago

PartLoader.LoadedPartsList contains a reference to the Kerbal prefabs for Making History even if they are not installed. So you have to null check them. OR... you can just use MM to amend the Prebuilt parts in stock and MH and not have to do it in code. TAC LS doesn't do that because it adds different resource amounts to the Kerbal parts depending on user settings.

linuxgurugamer commented 5 years ago

Thanks.