search

KSP-RO / TacLifeSupport

Life Support from Thunder Aerospace Corporation
Other
43 stars 24 forks source link

TAC LS / Background Resources - Multiple Issues - Solar/Fission/Deepfreeze #151

Open MrKiel opened 10 months ago

MrKiel commented 10 months ago

Hi,

Just to compile a list of issues with TAC LS, which I believe are mostly centred around background resources.

  1. b9 part switched solar panels (e.g. from near future solar) aren't recognised. Electrical generation in the background is extremely slow compared to stock panels (I assume it's defaulting to 1ec/sec) but oddly, electrical consumption is much higher as well. I tried two identical vessels, one with near future solar, and one with stock panels. The NF vessel had around 10x the power consumption in darkness compared to the vessel with stock panels (which, in darkness, doesn't really make sense). The result is that background processing is non-functional unless stock solar panels are used.

  2. near future fission generators have had their module names updated since this was last updated. The module names are now ModuleSystemHeatFissionReactor I believe, and the current power generation is CurrentElectricalGeneration.

Both of these issues mean that TAC LS & background processing are fairly broken :(

I've had a quick look through your code but can't see any obvious reasons for the solar panel issues. Finally:

  1. Quite a few errors in the logs relating to deepfreeze, which I assume means parts of that integration with background resources is broken as well: 
[LOG 15:25:27.627] 1/10/2024 3:25:27 PM,BackgroundResources-DFWrapper,Attempting to Grab DeepFreeze Types...
[LOG 15:25:27.634] 1/10/2024 3:25:27 PM,BackgroundResources-DFWrapper,DeepFreeze Version:0.31.0.0
[LOG 15:25:27.660] 1/10/2024 3:25:27 PM,BackgroundResources-DFWrapper,Got Assembly Types, grabbing Instance
[LOG 15:25:27.660] 1/10/2024 3:25:27 PM,BackgroundResources-DFWrapper,Failed grabbing Instance
clumzy commented 3 weeks ago

Seconding this, I'm having the exact same issue as #2 and just narrowed it down to TAC-LS background processing compatibility.

May I add that there's been an update to NFE in September 24 and some parts have been added, and all reactors have switched to the SystemHeat mod backend.

clumzy commented 3 weeks ago

@MrKiel @JPLRepo So I believe I've isolated the issue : More specifically this part of the code :

I don't know s**t about C# but I'll see what I can do on my side.