KSP-RO / TacLifeSupport

Life Support from Thunder Aerospace Corporation
Other
43 stars 24 forks source link

Reduce part count (rebased, example, WIP) #47

Open keyspace opened 7 years ago

keyspace commented 7 years ago

General discussion: #12

Most changes via shell scripts. Therefore monotonic, don't be alarmed by changed file count.

Major:

Minor:

TBD:

JPLRepo commented 7 years ago

There are way too many changes in this PR. Will take some time to look at this. And I don't agree with using firespitter as a hard dependency. I also think the community/users of TAC LS should be consulted first as the changes here are drastic. Also that needs to be considered is what is the impact on other mods such as Realism Overhaul?

keyspace commented 7 years ago

Post-factum thought: it would have been simpler to move all existing parts to Legacy, and introduce new switchable parts.

Also took a look at RO, where RealFuels is a dependency - so using a full Firespitter is truly out of place. A better approach would be to use a minimal code clone for those that don't use RO, and hand control over to RealFuels otherwise (which is already being done). Part incompatibility is a non-issue in this case, since RO introduces changes so drastic that a new game is a must.

Therefore OK to close IMO.

JPLRepo commented 7 years ago

Yes old parts should be legacy/still available or old saves get broken. I will discuss with RO post- 1.2 release as to the best way forward. I also forgot to mention that really with the Editor Filter that I implemented if this is that necessary as it seems the original motivation was simply that there were a lot of parts in the parts picker/ Utilities section. Parking this until post 1.2

JPLRepo commented 7 years ago

I have someone currently re-texturing the parts. Also the format of the TACGenericResourceConverter has changed to stock format. Some of the other changes are no longer appropriate either as I had already done them. (such as move DLLs).