search

KSP-RO / TestFlight

KSP Mod that provides a part research and reliability system
42 stars 31 forks source link

TestFlight refused to install #191

Closed 7ranceaddic7 closed 4 years ago

7ranceaddic7 commented 5 years ago

Problem:

TestFlight installation REQUIRES either RO/Config Stock. However, when installing with Config Stock, CKAN will abort the install because TF installs first and includes:

~/TestFlight/Config/ignore.txt

Solution:

Remove 'ignore.txt' from either TestFlight core. Since it is ostensibly a configuration file, it would (and should) be provided by any future config packs.

jwvanderbeck commented 5 years ago

To be honest, TF stopped officially supporting Stock configs a very long time ago as no one wanted to contribute to them.

7ranceaddic7 commented 5 years ago

Irrelevant, this is not an issue of properly supported/non-supported configs. It is an ill-place file that prevents proper installation.

jwvanderbeck commented 5 years ago

The stock configs are too far out of date. They don't even work properly anymore. If they were allowed to be installed then people would then just complain that they don't work.

Unless someone updated them to be working again?

7ranceaddic7 commented 5 years ago

Respectfully, the problem has NOTHING to do with the config files themselves.

As I proposed in my solution, simple remove ignore.txt from WHICHEVER install candidate you desire. I recommended the core candidate. Maybe y'all want it removed from the config candidate. Either works; problem solved.

HebaruSan commented 5 years ago

A zero byte "ignore.txt" file doesn't belong in any mod archive. I'd recommend removing it from both.

jwvanderbeck commented 5 years ago

I wouldn't just randomly create an ignore.txt file. There has to be a reason I did it, even if I can't recall what it was all these years later. My guess is it was there to prevent an empty directory being auto deleted.

But my understanding is it the file isn't the problem but the fact that the directory exists at all? Why does CKAN not have a "Force" or some such option to install even if the directory exists?

As I don't actively maintain this anymore, I'm not currently set up to build this project so best I can do is remove the folder and hope it doesn't cause any problems whenever the next release is made.

HebaruSan commented 5 years ago

There has to be a reason I did it

It looks like an artifact of trying to commit an empty folder in git, which isn't needed for a mod release ZIP.

jwvanderbeck commented 5 years ago

There has to be a reason I did it

It looks like an artifact of trying to commit an empty folder in git, which isn't needed for a mod release ZIP.

Yeah so the reason the file is there is so that the folder doesn't get deleted. This is because it is necessary for the CI scripts. Removing that file, makes the folder go away which breaks CI.

This is because the stock configs are created dynamically by a python chaser.

So to fix this I have to rewrite how the whole process works.

jwvanderbeck commented 4 years ago

Fixed with #197