search

KSP-RO / TestFlight

KSP Mod that provides a part research and reliability system
42 stars 31 forks source link

Restartable engine enhancements #218

Closed jwvanderbeck closed 3 years ago

jwvanderbeck commented 3 years ago

Purpose of this work is to enhance support for restartable engines. This is focused on three main features:

  1. Continuous rated run time
  2. Cumulative rated run time
  3. Minimum and maximum time between restarts

Currently Test Flight basically only handles point 2, cumulative rated run times.

jwvanderbeck commented 3 years ago

New config feature

TestFlightFailure_IgnitionFail

Added new FloatCurve restartWindowPenalty which can be used to define what additional penalty, if any, to apply to an ignition at a given time, in seconds, since last engine shutdown. This value is multiplied against the base ignition chance, so a value of 1 is no penalty, and a value less than 1 will reduce the chance of ignition.

TestFlightReliability_EngineCycle

Added new FloatCurve continuousCycle which is a failure rate modifier multiplied against the existing cycle modifier and the base failure rate based on the time, in seconds, that the engine has been running since it was last ignited.

Added new float ratedContinuousBurnTime which is the time, in seconds, that an engine is rated to run continuously without being shut down.

NOTE Existing cycle and ratedBurnTime values retain their conceptual meaning of cumulative burn time that was implicit before.

If a config is not updated for the new engine cycle, it should behave exactly as it did previously.

jwvanderbeck commented 3 years ago

The work so far is on the underlying mechanics, and some (if not all) of the various user facing displays are missing or even incorrect at this point.

jwvanderbeck commented 3 years ago

Currently has a major bug with ConfigNodes and is not useable

jwvanderbeck commented 3 years ago

NEW: Added API support for generic rating times NEW: Added MSD support for showing both cumulative and continuous run times NEW: Added UI/UX support for new features in various places

github-actions[bot] commented 3 years ago

Download the artifacts for this pull request:

jwvanderbeck commented 3 years ago

Considering this a candidate for release at this point in time, so testing is much appreciated. Grab the build from the bot comment above (it will always be the latest for this PR).