search

KSP-RO / TestFlight

KSP Mod that provides a part research and reliability system
42 stars 31 forks source link

configVersion 1 issues? #244

Closed pehvbot closed 2 years ago

pehvbot commented 2 years ago

Not sure if this is deliberate (or even real), but based on some preliminary tests, it looks like configVersion 1 configurations don't properly save part data in the latest version.

The SCENARIO/TestFlightManagerScenario/partData/partName is left blank for these parts. The effect is du for all configVersion 1 configured parts get dumped into this 'blank' partData entry and used for all these parts as a sort of common pool for these configs.

This is a bit of a tentative bug report because I haven't tried to fully replicate it for 'stock' TestFlight. I found it because of a TestFlight add-on I've been working on. I'm not 100% sure it's a bug on your end, but I'm able to solve it by moving the configs to configVersion 2 in the add-on.

jwvanderbeck commented 2 years ago

On the one hand I would say v1 probably isn't really supported any more. On the other hand though, Realism Overhaul was using v1 for a period of time before transitioning over to v2 so I would have thought everything sill worked. Unless it got broken in some recent update. I will say that Stock is definitely not supported anymore unless you've made your own configs and what not. The stock configs are beyond super out of date.

DRVeyl commented 2 years ago

Sorry, meant to reply when I saw this, but got pulled away.

I possibly did break this with the latest update. It is backwards-compatible with current v2 saves, but wasn't tested with v1. I think the version 1 support was a stop gap measure to make the transition to v2 with its initial release (TF 2.0, Mar 2021). I don't think v1 is still supported beyond that.

For existing saves, I believe the correct mitigation is to update to TF v2.0 or 2.1, load the save to convert the data format, and then upgrade again to TF latest (2.2).

From the dev side, as you point out, please update to use v2 configs.

jwvanderbeck commented 2 years ago

Yeah I would say at this point v1 configs just aren't supported expect to be migrated to v2

pehvbot commented 2 years ago

Thanks for the replies! Yes, it was a change in v2.2 and I expected that the older v1 stuff just wasn't being supported or looked at. I've already moved to configVersion2 and everything works fine. I just figured I would report it.