Add additional TestFlight data to editor and flight PAW

KSP-RO / TestFlight

KSP Mod that provides a part research and reliability system

42 stars 31 forks source link

Add additional TestFlight data to editor and flight PAW #254

Closed Falki-git closed 1 year ago

Falki-git commented 1 year ago

Goal is to add more engine PAW data similarly to how TestLite did it, so user doesn't have to use TestFlight's editor window.

Editor:
- Add current and max flight data
- Add current and max data reliability
- Add current and max data ignition chance
- Rated burn time: additionally display time in minutes for longer burn times (>60 sec), for ease of conversion
Flight:
- Add current and max flight data
- Color engine failures in orange

Editor: 1_editor

Flight: 2_flight

Flight failures: 3_flight_failure 4_flight_failure

jwvanderbeck commented 1 year ago

Why is this being merged into the burn planner branch? Did you manage to fix all the issues that @al2me6 had?

Falki-git commented 1 year ago

No, I don't know what issues @al2me6 had.

Work I independently started doing was loosely similar to what was done in the planner feature, so I continued on top of that.

jwvanderbeck commented 1 year ago

Sorry to be clear what I meant was this branch you are merging into had issues that were not fixed, thus any work you have done in it is going to still have those issues unless you've addressed them. As such if we merge your work into this branch - which is fine - it is still going to stay only here (and not go to master) until those issues have been fixed.

Alternatively you can instead do your work branching off master thus keeping your work separate. Does your own code have anything to do with the burn planner? If it doesn't and you don't need any of that code for your work, I would suggest redoing this branched off master.

Falki-git commented 1 year ago

My plan was to add relevant test flight info to engine PAW, since I missed that feature from TestLite. After I started I was made aware of this Burn planner feature which already added Rated burn time to PAW, which I was planning to add, so I started to build on top of that. I could branch from the dev or master, but the Rated burn time would conflict with Burn planner code. If that's an issues we're willing to solve when Burn planner is complete, then ok, I'll do it like that.

Having said that, I've tested this and haven't found any issues, everything is displayed nicely and engine configs update correctly. Maybe I just haven't encountered the issue yet? Looking at the previous PR, I don't understand what the issue is/was. If @al2me6 could enlighten us, that would be nice :)

Falki-git commented 1 year ago

Seeing as @al2me6 isn't active currently, I've made a a new PR #257 against the dev branch and will be closing this one.