KSP-RO / TestFlight

KSP Mod that provides a part research and reliability system
42 stars 31 forks source link

thrustModifier uses wrong Isp curve for throttle calculation #258

Closed ec429 closed 1 year ago

ec429 commented 1 year ago

I think I found out why thrustModifier isn't working in TF: it's using atmCurveIsp.Evaluate(0f) as part of its "throttle ratio" calculation (EngineModuleWrapper.commandedThrust), but that always returns 0. In TL I'm now using atmosphereCurve instead and it seems to work.

(Related: on https://github.com/KSP-RO/TestFlight/wiki/Module-Reference:-TestFlightReliability it claims that the keys to the curve are "thrust in kN"; AIUI that's incorrect.)

Capkirk123 commented 1 year ago

Resolved with #252