KSP-RO / TestFlight

KSP Mod that provides a part research and reliability system
42 stars 31 forks source link

PAW Ignition Chance broken for solids #262

Closed lpgagnon closed 11 months ago

lpgagnon commented 1 year ago

2.3.0's new reliability-in-PAW feature is partially broken for SRMs: the "ignition chance" fields are always zero. Other fields look fine; Ignition Chance is fine for liquide-fueled engines

All SRMs seem affected; I checked RO's small sep motor and all Scout stages.

Screenshot 2023-01-12 at 20 23 45

Only happens in VAB; chance is non-zero in flight scene and appears correct.

jwvanderbeck commented 1 year ago

Do solids even have an ignition fail module? I mean they can't fail to ignite can they?

On Thu, Jan 12, 2023 at 8:26 PM Louis-Philippe Gagnon < @.***> wrote:

2.3.0's new reliability-in-PAW feature is partially broken for SRMs: the "ignition chance" fields are always zero. Other fields look fine; Ignition Chance is fine for liquide-fueled engines

All SRMs seem affected; I checked RO's small sep motor and all Scout stages. [image: Screenshot 2023-01-12 at 20 23 45] https://user-images.githubusercontent.com/5061230/212215849-36f8aeee-c9a4-4666-bb0f-619b6e4f301a.png

— Reply to this email directly, view it on GitHub https://github.com/KSP-RO/TestFlight/issues/262, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABHKZTL2BJDZDBIGURT7M3WSCVNBANCNFSM6AAAAAATZ353VA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lpgagnon commented 1 year ago

they do and they can.

https://github.com/KSP-RO/RealismOverhaul/blob/8a2d84902e29d2a968dc1c03aeddbb996e35885c/GameData/RealismOverhaul/Engine_Configs/Castor_1_Config.cfg#L276-L283

Screenshot 2023-01-12 at 21 21 11
        MODULE
        {
            name = TestFlightFailure_IgnitionFail
            configVersion = 2
            CONFIG
            {
                configuration = Antares-I
                additionalFailureChance = 0.2
                restoreIgnitionCharge = False
                duFail = 1050
                oneShot = True
                failureType = mechanical
                failureTitle = Failed to ignite
                ignorePressureOnPad = True
                severity = major
                pressureCurve
                {
                    key = 0 1 0 0
                }
                baseIgnitionChance
                {
                    key = 0 0.91129
                    key = 3000 0.964516 4.81568571428571E-06 4.81568571428571E-06
                    key = 10000 0.982258 0 0
                }
                restartWindowPenalty
                {
                    key = 0 1
                    key = 1 1
                }
            }
        }

in flight scene:

Screenshot 2023-01-12 at 21 24 30
Falki-git commented 1 year ago

PR https://github.com/KSP-RO/TestFlight/pull/263 will fix the issue. May I ask for a test?

Falki-git commented 1 year ago

Tested it a bit more in my gaming instance, works good now with https://github.com/KSP-RO/TestFlight/pull/263