search

KSP-SpaceDock / SpaceDock

Current Codebase (Python /Flask)
https://spacedock.info
Other
73 stars 33 forks source link

Refactoring the codebase into SpaceDock "branding" #16

Closed ghost closed 8 years ago

ghost commented 8 years ago

To achieve as clean a change over as possible, we should refactor the KerbalStuff modules / classes into SpaceDock references. It is much less confusing to work with the code base that way.

EIREXE commented 8 years ago

Not really, it's a completely unecessary change that could bring issues in the future.

EIREXE commented 8 years ago

It will also surely break the ability to grab code from other forks, so I would suggest against it.

GenPage commented 8 years ago

It's definitely an option, as we refactor code and develop new modules. I don't think its necessary to refactor all the modules and classes immediately, but definitely something to consider as we continue development

ghost commented 8 years ago

Especially since @ThomasKerman is developing the KS codebase into something more configurable.

So, the real question is: Whither KerbalStuff's codebase? Do we want to develop for just the special case of KSP, or the more general case of mod hosting (with an eye to the KSP community's needs first)?

EIREXE commented 8 years ago

@phmayo keeping the naming is a better plan, as people can then incorporate stuff from this into kerbalstuff forks.

ghost commented 8 years ago

Well, do we care about that? We do have a chance to have breaking changes, and develop this further than it is right now.

StollD commented 8 years ago

The KerbalStuff core libraries should stay named KerbalStuff, but I suggest that we put new classes and modules we develop under the SpaceDock name. This will make clear that the code is not KS, and we will maintain compatibility to other forks